Fix type/type-min CI: suppress argcomplete unresolved-import#3729
Closed
worksbyfriday wants to merge 1 commit intotox-dev:mainfrom
Closed
Fix type/type-min CI: suppress argcomplete unresolved-import#3729worksbyfriday wants to merge 1 commit intotox-dev:mainfrom
worksbyfriday wants to merge 1 commit intotox-dev:mainfrom
Conversation
…mport argcomplete is an optional dependency (extras=["completion"]) that may not be installed in the type check environment. ty flags the import as unresolved-import, causing type/type-min CI jobs to fail. The import in parse.py is already guarded with try/except ImportError, and the test file only runs when argcomplete is installed. Adding ty: ignore comments aligns with the existing pattern used for other optional imports (e.g., _overlapped, pty, termios in local_sub_process). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
typeandtype-minCI jobs fail becausety checkcannot resolve theargcompleteimport:argcompleteis an optional dependency underextras=["completion"]and may not be installed in the type check environment. The import inparse.pyis already guarded withtry/except ImportError, and the test file only runs when argcomplete is available.Changes
Added
# ty: ignore[unresolved-import]comments to both import sites, matching the existing pattern used for other optional/platform-specific imports (e.g.,_overlapped,pty,termiosinlocal_sub_process/__init__.py).Test plan