Skip to content

Provision lock#2516

Merged
gaborbernat merged 7 commits intotox-dev:masterfrom
masenf:provision-lock
Oct 25, 2022
Merged

Provision lock#2516
gaborbernat merged 7 commits intotox-dev:masterfrom
masenf:provision-lock

Conversation

@masenf
Copy link
Copy Markdown
Contributor

@masenf masenf commented Oct 10, 2022 •
edited
Loading

Fixes #2515

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example: 
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

masenf added 2 commits October 10, 2022 23:39
@masenf
test_provision_int: test_provision_race
ae380fd 
kick off two processes that need to provision the tox environment and
ensure they don't stomp on each other in the process.
@masenf
provision: take a lock for provision_tox_env
9cc2367 
avoid race condition when `.tox` environment needs to be provisioned
gaborbernat
gaborbernat reviewed Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is broken, do you plan to fix it?

@masenf
Copy link
Copy Markdown
Contributor Author

masenf commented Oct 25, 2022

@gaborbernat if the change itself looks reasonable, I will fix the CI issues and update change log and contributors.

This came out of a bug discovered "at work", I'll circle back on it today and clean up.

masenf added 4 commits October 25, 2022 20:30
@masenf
test_provision_int: fix <py36 support
ca06395 
subprocess.Popen didn't accept the `encoding` kwarg.

rather than attempting other tricks, just match the output as an
explicit bytestring, which will work on any interpreter.
@masenf
docs/config: mention provision_tox_env behavior change
e056af0
@masenf
add Masen Furer to CONTRIBUTORS
804f8c1 
as per PR checklist
@masenf
changelog: issue tox-dev#2515
53c1c5f 
add changelog information about issue tox-dev#2515
@masenf
changelog: fixup: use double backticks
59071f4 
rst ``code`` is two backticks.................................Failed
- hook id: rst-backticks
- exit code: 1
@masenf
Copy link
Copy Markdown
Contributor Author

masenf commented Oct 25, 2022

@gaborbernat i believe this is now ready for review

@gaborbernat gaborbernat merged commit e378131 into tox-dev:master Oct 25, 2022
@mikelane mikelane mentioned this pull request Oct 26, 2022
Merged
@masenf masenf deleted the provision-lock branch January 18, 2023 04:25
This was referenced Aug 24, 2023
Open
Open
Open
Open
Open
Closed
Open
Open
@renovate renovate bot mentioned this pull request Sep 2, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@asottile asottile Awaiting requested review from asottile

@obestwalter obestwalter Awaiting requested review from obestwalter

@jugmac00 jugmac00 Awaiting requested review from jugmac00

Assignees

No one assigned

Labels

bot:chronographer:provided

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

multiple tox instances will clobber the .tox directory when provision_tox_env is used

2 participants

@masenf @gaborbernat