Fix fallback to "python" environment when "isolated_build = true" is set#2475
Merged
gaborbernat merged 2 commits intotox-dev:masterfrom Aug 8, 2022
Merged
Fix fallback to "python" environment when "isolated_build = true" is set#2475gaborbernat merged 2 commits intotox-dev:masterfrom
gaborbernat merged 2 commits intotox-dev:masterfrom
Conversation
Skip the section generated by ``isolated_build = true`` when collection all environments instead of removing the ``isolated_build_env`` afterwards.
gaborbernat
requested changes
Aug 8, 2022
Member
gaborbernat
left a comment
There was a problem hiding this comment.
You'll need to add a test for this.
Author
|
I've added a unit test. |
gaborbernat
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the section generated by
isolated_build = truewhen collection all environments instead of removing theisolated_build_envafterwards.Fixes #2474
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
CONTRIBUTORS(preserving alphabetical order)