Use gethostname instead of potentially slow getfqdn#2380
Merged
gaborbernat merged 1 commit intotox-dev:masterfrom Mar 18, 2022
Merged
Use gethostname instead of potentially slow getfqdn#2380gaborbernat merged 1 commit intotox-dev:masterfrom
gaborbernat merged 1 commit intotox-dev:masterfrom
Conversation
This avoid bug that is adding 30s on some machines where getfqdn() is very slow, as this is caused by an unsolved python bug. Related: https://bugs.python.org/issue35164 Fixes: tox-dev#2375
361d991 to
927312b
Compare
gaborbernat
approved these changes
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoid bug that is adding 30s on some machines where getfqdn()
is very slow, as this is caused by an unsolved python bug.
Related: https://bugs.python.org/issue35164
Fixes: #2375
Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc-- by :user:`<your username>`.CONTRIBUTORS(preserving alphabetical order)