Passenv: Include default env variables regardless of their case on UNIX#2378
Merged
gaborbernat merged 1 commit intotox-dev:masterfrom Mar 18, 2022
Merged
Passenv: Include default env variables regardless of their case on UNIX#2378gaborbernat merged 1 commit intotox-dev:masterfrom
gaborbernat merged 1 commit intotox-dev:masterfrom
Conversation
This fixes problems with environment variables that are also used in their lower-case form, such as http_proxy and https_proxy. This applies only to UNIX systems since Windows is case-insensitive. Closes tox-dev#2372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This fixes problems with environment variables that are also used in their lower-case form on UNIX systems, such as
http_proxyandhttps_proxy. They wouldn't be passed on to the test environment, while variables such asHTTP_PROXYwould.Closes #2372
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc-- by :user:`<your username>`.CONTRIBUTORS(preserving alphabetical order)