Fix #2332#2333
Merged
gaborbernat merged 4 commits intotox-dev:masterfrom Jan 26, 2022
zariiii9003:bugfix
Merged
Conversation
gaborbernat
reviewed
Jan 25, 2022
gaborbernat
requested changes
Jan 25, 2022
Member
gaborbernat
left a comment
There was a problem hiding this comment.
Let's add a test here. And a changelog should go into a news fragment file, not directly to the changelog one 👍
for more information, see https://pre-commit.ci
gaborbernat
reviewed
Jan 25, 2022
Author
Tbh i have zero knowledge about the inner workings of this library and i don't know how to test this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2332
build_requires.py caught a setuptools warning so
json.loads()failed in isolated.py.I disabled the capturing of stderr.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc-- by :user:`<your username>`.CONTRIBUTORS(preserving alphabetical order)