Skip to content

Better selection support#2290

Merged
gaborbernat merged 5 commits intotox-dev:rewritefrom
gaborbernat:better-sel
Jan 4, 2022
Merged

Better selection support#2290
gaborbernat merged 5 commits intotox-dev:rewritefrom
gaborbernat:better-sel

Conversation

@gaborbernat
Copy link
Copy Markdown
Member

Signed-off-by: Bernát Gábor gaborjbernat@gmail.com

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Copy link
Copy Markdown
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

This should fix #238.

I have one minor inline comment.

Also, if possible, please add some documentation.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@ericchansen
Copy link
Copy Markdown

I'm trying to learn how to use this feature, and I'm struggling. Is there any particular docs I should focus on? Or perhaps certain tests that demonstrate the feature well?

@gaborbernat
Copy link
Copy Markdown
Member Author

What you looking to achieve?

@jugmac00
Copy link
Copy Markdown
Member

I'm trying to learn how to use this feature, and I'm struggling. Is there any particular docs I should focus on? Or perhaps certain tests that demonstrate the feature well?

Does this link answer your question? https://tox.wiki/en/rewrite/config.html#labels

If not, please create an issue.

@ericchansen
Copy link
Copy Markdown

ericchansen commented Apr 25, 2022

@jugmac00, I read that before making this comment, but thank you!

@gaborbernat I want to create a new env that runs in almost the same way as the default env except it has more extras. I'll try to give a minimal example.

[tox]
envlist = py36, py37, py38, py39
minversion = 3.15

[testenv]
description = Invoke pytest to run automated tests
commands =
    pytest \
        --cov \
        --cov-append \
        --junitxml {toxworkdir}/junit.{envname}.xml \
        src/tests
        {posargs}
extras =
    testing
passenv =
    HOME
setenv =
    COVERAGE_FILE = {env:COVERAGE_FILE:{toxworkdir}/.coverage.{envname}}
    TOXINIDIR = {toxinidir}

[testenv:gitlab]
extras =
    gitlab
    testing

I want the gitlab env to do the same thing as the default env (run the tests on py36, py37, etc.), except also install a few more additional dependencies.

EDIT: Sorry, didn't see your updated comment which asked me to create a new issue. I will do so.

@jugmac00
Copy link
Copy Markdown
Member

jugmac00 commented Apr 25, 2022

Please do not hijack this pull request and create a discussion - thank you.

@rpkilby rpkilby mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants