Skip to content

Replace pytest-console-scripts plugin with smaller in-house solution#476

Merged
kemzeb merged 3 commits intotox-dev:mainfrom
kemzeb:test/remove-pytest-console-scripts
Apr 30, 2025
Merged

Replace pytest-console-scripts plugin with smaller in-house solution#476
kemzeb merged 3 commits intotox-dev:mainfrom
kemzeb:test/remove-pytest-console-scripts

Conversation

@kemzeb
Copy link
Copy Markdown
Collaborator

@kemzeb kemzeb commented Apr 29, 2025

Resolves #474.

Due to us using the stdlib importlib.metadata and pytest-console-scripts using the backport version for Python versions < 3.10, this has caused some problems when importlib_metadata upgrades to a version that makes changes which is incompatible with the stdlib version.

After analyzing this plugin and the stdlib version of importlib.metadata, I ultimately decided to remove this plugin in favor of using Distribution.entry_points() to get the console script.

@kemzeb kemzeb requested a review from gaborbernat April 29, 2025 02:57
@kemzeb kemzeb marked this pull request as draft April 29, 2025 03:02
@kemzeb kemzeb marked this pull request as ready for review April 29, 2025 03:16
@kemzeb kemzeb merged commit 3136fd1 into tox-dev:main Apr 30, 2025
11 checks passed
@kemzeb kemzeb deleted the test/remove-pytest-console-scripts branch April 30, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failures for 3.9

2 participants