Fix misspelled keyword argument poll_interval for method acquire#119
Merged
gaborbernat merged 5 commits intotox-dev:mainfrom Nov 16, 2021
XuehaiPan:fix-typo
Merged
Fix misspelled keyword argument poll_interval for method acquire#119gaborbernat merged 5 commits intotox-dev:mainfrom XuehaiPan:fix-typo
poll_interval for method acquire#119gaborbernat merged 5 commits intotox-dev:mainfrom
XuehaiPan:fix-typo
Conversation
gaborbernat
requested changes
Nov 16, 2021
gaborbernat
reviewed
Nov 16, 2021
gaborbernat
requested changes
Nov 16, 2021
Member
gaborbernat
left a comment
There was a problem hiding this comment.
Can you please add a test to validate this?
Contributor
Author
|
I think we can reimplement this by using decorators without changing the signature of the method. |
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Member
I think the current implementation is fine, no need for decorators. |
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
gaborbernat
approved these changes
Nov 16, 2021
Member
|
Thanks for your contribution. |
|
I don't know where it's coming from (maybe virtualenv?) but I'm getting a lot of warnings: |
Contributor
Author
@ofek Can you try to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix misspelled keyword argument
poll_intervalfor methodacquire. Fixes #62.I tried my best to add the backward compatibility layer in this PR to not break existing codebases.