Skip to content

feat: updated dark theme#5

Merged
tovifun merged 1 commit into
tovifun:mainfrom
clementpoiret:feat/dark-theme-proposal
Jul 28, 2023
Merged

feat: updated dark theme#5
tovifun merged 1 commit into
tovifun:mainfrom
clementpoiret:feat/dark-theme-proposal

Conversation

@clementpoiret

Copy link
Copy Markdown

First, I'd like to say: wow! Very nice job :D
I just find the dark theme to be a bit strange compared to the light one, and as I like switching from light to dark based on the hour, I add a darker gradient and update the "too yellow" yellow, by a darker one matching the proposed gradient.

Screenshot:
Screenshot from 2023-07-28 15:25:47

I hope you'll like it :)

Anyway, you leveled up my vivaldi, it's awesome!

@clementpoiret

clementpoiret commented Jul 28, 2023

Copy link
Copy Markdown
Author

ps: the original dark theme is the ArcDarkPure.zip (matching the name in settings.json), mine is ArcDark.zip

@tovifun tovifun merged commit 2b5ee72 into tovifun:main Jul 28, 2023
@tovifun

tovifun commented Jul 28, 2023

Copy link
Copy Markdown
Owner

This theme looks great!👏 I've already merged it. Also, I just realized that if the address bar is open, I can optimize the color of the address bar so that it's not two black input boxes.😂

@tovifun

tovifun commented Jul 28, 2023

Copy link
Copy Markdown
Owner

BTW, may I ask what OS system are you using? It looks very harmonious as a whole.😍

@clementpoiret

Copy link
Copy Markdown
Author

Thanks! Yeah that's a great idea for the address and search bars :)
And thanks for the comment on the OS, I use EndeavourOS, with Hyprland window manager, and waybar.
Hyprland is sometimes a bit buggy, mostly because of the combo Nvidia GPU + Wayland, but when everything is setup that's awesome!

@tovifun

tovifun commented Jul 28, 2023

Copy link
Copy Markdown
Owner

It's really cool!

@themysteryboy

Copy link
Copy Markdown

First, I'd like to say: wow! Very nice job :D I just find the dark theme to be a bit strange compared to the light one, and as I like switching from light to dark based on the hour, I add a darker gradient and update the "too yellow" yellow, by a darker one matching the proposed gradient.

Screenshot: Screenshot from 2023-07-28 15:25:47

I hope you'll like it :)

Anyway, you leveled up my vivaldi, it's awesome!

can u share how do u make the close and other buttons disappear in linux with hyprland wm?

@clementpoiret

clementpoiret commented Aug 12, 2023

Copy link
Copy Markdown
Author

can u share how do u make the close and other buttons disappear in linux with hyprland wm?

Here is my hyprland config :) https://github.com/clementpoiret/dotfiles/blob/main/dot_config/hypr/hyprland.conf
(Warning: since last update, blur config is broken, I need to fix that)

@clementpoiret

Copy link
Copy Markdown
Author

themysteryboy Hmm I just made a fresh install of hyprland on another computer, and I got the buttons you want to hide. Strange. I fixed it by force vivaldi to be in tile mode:

windowrulev2 = tile, class:^(Vivaldi-stable)$

Depending on your install, the class name can change, you can check it when you have an open vivaldi window using hyprctl clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants