Skip to content

Feature/appcircle support#1

Merged
tosbaha merged 3 commits into
masterfrom
feature/appcircle-support
Sep 14, 2022
Merged

Feature/appcircle support#1
tosbaha merged 3 commits into
masterfrom
feature/appcircle-support

Conversation

@tosbaha

@tosbaha tosbaha commented Sep 14, 2022

Copy link
Copy Markdown
Owner

///////////////////⚡///////////////////

🚫 AWESOME A PR!

  • You can just delete all of this and start your PR text anytime -

Hello there, just a quick pre-warning of some of the Danger rules we run on Danger PRs.

The big one is we request that every code change to Danger include a CHANGELOG entry,
this is so that:

  1. People know what changes are between versions
  2. Orta doesn't get all the credit for other people's work

Danger will look for a modification to the CHANGELOG.md when there are changes including
lib/* - if you're fixing unreleased code, or doing a simple typo change, you can
include #trivial in the title or the body of the PR and this is skipped.

We also request that you fill in the body of your PR, a title should be tweet length, but
ideally you can explain the PRs reasoning in the body. We look that it's longer than 5 chars.

Other than that, a lot of the other Danger rules are trickier to trigger so we can address
them as they come up!

❤ THANKS FOR HELPING OUT :D

///////////////////⚡///////////////////

@tosbaha tosbaha merged commit e2b6a82 into master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant