Feature/appcircle support#1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
///////////////////⚡///////////////////
🚫 AWESOME A PR!
Hello there, just a quick pre-warning of some of the Danger rules we run on Danger PRs.
The big one is we request that every code change to Danger include a CHANGELOG entry,
this is so that:
Danger will look for a modification to the
CHANGELOG.mdwhen there are changes includinglib/*- if you're fixing unreleased code, or doing a simple typo change, you caninclude
#trivialin the title or the body of the PR and this is skipped.We also request that you fill in the body of your PR, a title should be tweet length, but
ideally you can explain the PRs reasoning in the body. We look that it's longer than 5 chars.
Other than that, a lot of the other Danger rules are trickier to trigger so we can address
them as they come up!
❤ THANKS FOR HELPING OUT :D
///////////////////⚡///////////////////