platform: mellanox: mlx-platform: Move bus shift assignment out of the loop

vadimp-nvidia · jwrdegoede · commit 50b823fdd357 · 2023-02-13T12:07:50.000+01:00
Move assignment of bus shift setting out of the loop to avoid redundant operation. Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> Reviewed-by: Michael Shych <michaelsh@nvidia.com> Link: https://lore.kernel.org/r/20230208063331.15560-13-vadimp@nvidia.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
@@ -6008,10 +6008,11 @@ static int mlxplat_mlxcpld_verify_bus_topology(int *nr)
 		shift = *nr - mlxplat_mux_data[i].parent;
 		mlxplat_mux_data[i].parent = *nr;
 		mlxplat_mux_data[i].base_nr += shift;
-		if (shift > 0)
-			mlxplat_hotplug->shift_nr = shift;
 	}
 
+	if (shift > 0)
+		mlxplat_hotplug->shift_nr = shift;
+
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -6008,10 +6008,11 @@ static int mlxplat_mlxcpld_verify_bus_topology(int *nr)`
`6008`	`6008`	`shift = *nr - mlxplat_mux_data[i].parent;`
`6009`	`6009`	`mlxplat_mux_data[i].parent = *nr;`
`6010`	`6010`	`mlxplat_mux_data[i].base_nr += shift;`
`6011`		`- if (shift > 0)`
`6012`		`- mlxplat_hotplug->shift_nr = shift;`
`6013`	`6011`	`}`
`6014`	`6012`
	`6013`	`+ if (shift > 0)`
	`6014`	`+ mlxplat_hotplug->shift_nr = shift;`
	`6015`	`+`
`6015`	`6016`	`return 0;`
`6016`	`6017`	`}`
`6017`	`6018`