Skip to content

Commit 4289fd4

Browse files
vadimp-nvidiajwrdegoede
authored andcommitted
platform/x86: mlx-platform: Add BIOS attributes for CoffeeLake COMEx based systems
Extend systems of class VMOD0010 equipped with CoffeeLake COMEx module with BIOS related attributes to represent various BIOS statuses. These attributes "bios_active_image", "bios_auth_fail", "bios_upgrade_fail", "bios_safe_mode" has been already added to modular system. This all of them are already documented. - "bios_active_image" - location of current active BIOS image (0: Top, 1: Bottom. The reported value should correspond to value expected by OS in case of BIOS safe mode is 0. This bit is related to Intel top-swap feature of DualBios on the same flash. - "bios_auth_fail": BIOS upgrade is failed because provided BIOS image is not signed correctly. - "bios_upgrade_fail" BIOS upgrade is failed by some reason not related to authentication. For example, due to physical SPI flash problem. - "bios_safe_mod": - 0 : if BIOS is booted from a supposed active image; 1 : BIOS safe mechanism was enforced by hardware (CPLD). Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> Reviewed-by: Oleksandr Shamray <oleksandrs@nvidia.com> Link: https://lore.kernel.org/r/20211023094022.4193813-3-vadimp@nvidia.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 9045512 commit 4289fd4

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

drivers/platform/x86/mlx-platform.c

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2917,6 +2917,30 @@ static struct mlxreg_core_data mlxplat_mlxcpld_default_ng_regs_io_data[] = {
29172917
.bit = GENMASK(7, 0),
29182918
.mode = 0444,
29192919
},
2920+
{
2921+
.label = "bios_safe_mode",
2922+
.reg = MLXPLAT_CPLD_LPC_REG_GPCOM0_OFFSET,
2923+
.mask = GENMASK(7, 0) & ~BIT(4),
2924+
.mode = 0444,
2925+
},
2926+
{
2927+
.label = "bios_active_image",
2928+
.reg = MLXPLAT_CPLD_LPC_REG_GPCOM0_OFFSET,
2929+
.mask = GENMASK(7, 0) & ~BIT(5),
2930+
.mode = 0444,
2931+
},
2932+
{
2933+
.label = "bios_auth_fail",
2934+
.reg = MLXPLAT_CPLD_LPC_REG_GPCOM0_OFFSET,
2935+
.mask = GENMASK(7, 0) & ~BIT(6),
2936+
.mode = 0444,
2937+
},
2938+
{
2939+
.label = "bios_upgrade_fail",
2940+
.reg = MLXPLAT_CPLD_LPC_REG_GPCOM0_OFFSET,
2941+
.mask = GENMASK(7, 0) & ~BIT(7),
2942+
.mode = 0444,
2943+
},
29202944
{
29212945
.label = "voltreg_update_status",
29222946
.reg = MLXPLAT_CPLD_LPC_REG_GP0_RO_OFFSET,

0 commit comments

Comments
 (0)