platform: mellanox: mlx-platform: Initialize shift variable to 0

jwrdegoede · jwrdegoede · commit 1a0009abfa78 · 2023-03-07T12:08:30.000+01:00
Initialize shift variable in mlxplat_mlxcpld_verify_bus_topology() to 0 to avoid the following compile error: drivers/platform/x86/mlx-platform.c:6013 mlxplat_mlxcpld_verify_bus_topology() error: uninitialized symbol 'shift'. Fixes: 50b823f ("platform: mellanox: mlx-platform: Move bus shift assignment out of the loop") Cc: Vadim Pasternak <vadimp@nvidia.com> Cc: Michael Shych <michaelsh@nvidia.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230307105842.286118-1-hdegoede@redhat.com
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
@@ -5980,7 +5980,7 @@ MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
 static int mlxplat_mlxcpld_verify_bus_topology(int *nr)
 {
 	struct i2c_adapter *search_adap;
-	int shift, i;
+	int i, shift = 0;
 
 	/* Scan adapters from expected id to verify it is free. */
 	*nr = MLXPLAT_CPLD_PHYS_ADAPTER_DEF_NR;

Original file line number	Diff line number	Diff line change
`@@ -5980,7 +5980,7 @@ MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);`
`5980`	`5980`	`static int mlxplat_mlxcpld_verify_bus_topology(int *nr)`
`5981`	`5981`	`{`
`5982`	`5982`	`struct i2c_adapter *search_adap;`
`5983`		`- int shift, i;`
	`5983`	`+ int i, shift = 0;`
`5984`	`5984`
`5985`	`5985`	`/* Scan adapters from expected id to verify it is free. */`
`5986`	`5986`	`*nr = MLXPLAT_CPLD_PHYS_ADAPTER_DEF_NR;`