Skip to content

Add test for tracker::service::get_torrent_info#421

Merged
josecelano merged 2 commits into
torrust:developfrom
josecelano:issue-391-tracker-api-patch
Dec 26, 2023
Merged

Add test for tracker::service::get_torrent_info#421
josecelano merged 2 commits into
torrust:developfrom
josecelano:issue-391-tracker-api-patch

Conversation

@josecelano

@josecelano josecelano commented Dec 26, 2023

Copy link
Copy Markdown
Member

It seems there is a bug but I cannot reproduce it. It should not reach the line that produces the error message:

Failed to parse torrent info from tracker response. Body: "torrent not known"

Added some tests and simplified code.

…_torrent_info

It seems there is a bug but I cannot reproduce it.
@josecelano josecelano linked an issue Dec 26, 2023 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Dec 26, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.99%. Comparing base (471ec38) to head (219dff0).
⚠️ Report is 549 commits behind head on develop.

Files with missing lines Patch % Lines
src/tracker/service.rs 87.50% 6 Missing ⚠️
src/models/torrent_file.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #421      +/-   ##
===========================================
+ Coverage    42.24%   42.99%   +0.74%     
===========================================
  Files           80       80              
  Lines         4890     4922      +32     
===========================================
+ Hits          2066     2116      +50     
+ Misses        2824     2806      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josecelano

Copy link
Copy Markdown
Member Author

ACK 219dff0

@josecelano josecelano merged commit 373493f into torrust:develop Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Patch for Tracker API response is not working

2 participants