Skip to content

Development Checks workflow is not failing when E2E tests fail #189

@josecelano

Description

@josecelano

The PR #162 was merged and today I've realized there were some broken tests.

test e2e::contexts::torrent::contract::for_guests::it_should_allow_guests_to_get_torrents ... FAILED
test e2e::contexts::torrent::contract::for_guests::it_should_allow_to_get_torrents_with_pagination ... FAILED
test e2e::contexts::torrent::contract::for_guests::it_should_return_a_default_amount_of_torrents_per_request_if_no_page_size_is_provided ... FAILED
test e2e::contexts::torrent::contract::for_guests::it_should_allow_to_limit_the_number_of_torrents_per_request ... FAILED

It seems the pagination has been broken with the changes introduced to support "tags".

See https://github.com/torrust/torrust-index-backend/actions/runs/5209788641/jobs/9400067078#step:13:1336

This issue is to fix the workflow, not the tests. I've created another issue to fix the tests.

failures:

---- e2e::contexts::torrent::contract::for_guests::it_should_allow_guests_to_get_torrents stdout ----
Loading configuration for E2E env from config file `./config-idx-back.local.toml`
thread 'e2e::contexts::torrent::contract::for_guests::it_should_allow_guests_to_get_torrents' panicked at 'called `Result::unwrap()` on an `Err` value: Error("missing field `data`", line: 1, column: 33)', tests/e2e/contexts/torrent/contract.rs:50:95

---- e2e::contexts::torrent::contract::for_guests::it_should_allow_to_get_torrents_with_pagination stdout ----
Loading configuration for E2E env from config file `./config-idx-back.local.toml`
thread 'e2e::contexts::torrent::contract::for_guests::it_should_allow_to_get_torrents_with_pagination' panicked at 'called `Result::unwrap()` on an `Err` value: Error("missing field `data`", line: 1, column: 33)', tests/e2e/contexts/torrent/contract.rs:79:95

---- e2e::contexts::torrent::contract::for_guests::it_should_return_a_default_amount_of_torrents_per_request_if_no_page_size_is_provided stdout ----
Loading configuration for E2E env from config file `./config-idx-back.local.toml`
thread 'e2e::contexts::torrent::contract::for_guests::it_should_return_a_default_amount_of_torrents_per_request_if_no_page_size_is_provided' panicked at 'called `Result::unwrap()` on an `Err` value: Error("missing field `data`", line: 1, column: 33)', tests/e2e/contexts/torrent/contract.rs:145:95

---- e2e::contexts::torrent::contract::for_guests::it_should_allow_to_limit_the_number_of_torrents_per_request stdout ----
Loading configuration for E2E env from config file `./config-idx-back.local.toml`
thread 'e2e::contexts::torrent::contract::for_guests::it_should_allow_to_limit_the_number_of_torrents_per_request' panicked at 'called `Result::unwrap()` on an `Err` value: Error("missing field `data`", line: 1, column: 33)', tests/e2e/contexts/torrent/contract.rs:114:95


failures:
    e2e::contexts::torrent::contract::for_guests::it_should_allow_guests_to_get_torrents
    e2e::contexts::torrent::contract::for_guests::it_should_allow_to_get_torrents_with_pagination
    e2e::contexts::torrent::contract::for_guests::it_should_allow_to_limit_the_number_of_torrents_per_request
    e2e::contexts::torrent::contract::for_guests::it_should_return_a_default_amount_of_torrents_per_request_if_no_page_size_is_provided

test result: FAILED. 40 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 56.33s

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugIncorrect Behavior

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions