Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Greptile Summary

This PR delivers a clean full-stack implementation of IFAC (network_name / passphrase) support for RNode LoRa interfaces, mirroring the existing TCP path end-to-end: data model → JSON serialization/deserialization → Kotlin→Python bridge → config file / pending-config dict → ColumbaRNodeInterface.__init__ → ViewModel → UI (both the settings dialog and the RNode wizard). The IfacFields composable refactor is a nice DRY improvement. The previous review concern about asymmetric .trim() on passphrase has been resolved — it is now applied consistently for both TCP and RNode in InterfaceManagementViewModel and RNodeWizardViewModel.\n\nKey changes:\n- InterfaceConfig.RNode gains nullable networkName/passphrase fields; serialization/deserialization are symmetric.\n- reticulum_wrapper.py writes IFAC lines to the TCP RNode INI config and stores them in the BT/USB pending dict.\n- rnode_interface.py reads the raw passphrase into ifac_netkey; the updated comment correctly notes RNS.Transport performs key derivation.\n- Edit mode in the RNode wizard now skips straight to the review step with showAdvancedSettings = true, which is a sensible UX improvement (and required for IFAC fields to be visible on edit).\n- Test coverage spans all four new code paths (serialization, TCP config gen, BT/USB pending dict, __init__ init).\n\nOne P2 suggestion: the network_name and passphrase strings are the first user-entered free-text values written unquoted into the Reticulum INI config file. A defensive newline-strip on the Python write path would match the single-line constraint already enforced by the UI.

Confidence Score: 5/5

Safe to merge; the implementation is correct and the only open item is a defensive best-practice in the Python config writer.

All four code paths are covered by tests, the full-stack data flow is consistent, previous review concerns about passphrase trim asymmetry are resolved, and the one remaining P2 (newline strip) is a minor hardening suggestion rather than a functional bug given the UI already enforces single-line input.

python/reticulum_wrapper.py — unquoted string values written to INI config without newline sanitization.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant UI as InterfaceConfigDialog / ReviewConfigStep
    participant VM as ViewModel (IMVM / RNodeWizardVM)
    participant Repo as InterfaceRepository
    participant Proto as ServiceReticulumProtocol
    participant Py as reticulum_wrapper.py
    participant IF as ColumbaRNodeInterface

    UI->>VM: onConfigUpdate(networkName, passphrase)
    VM->>Repo: save InterfaceConfig.RNode(networkName, passphrase)
    Repo-->>VM: persisted

    VM->>Proto: send RNode JSON (network_name, passphrase)
    Proto->>Py: JSON over Kotlin→Python bridge

    alt TCP connection mode
        Py->>Py: _create_config_file()<br/>write network_name / passphrase to INI
        Note over Py: RNS reads config → starts TCP RNode
    else BT / USB connection mode
        Py->>Py: store in _pending_rnode_configs dict
        Py->>IF: ColumbaRNodeInterface(config)
        IF->>IF: ifac_netname = config["network_name"]<br/>ifac_netkey = config["passphrase"]
        Note over IF: RNS.Transport derives IFAC key
    end

This is a comment left during a code review.
Path: python/reticulum_wrapper.py
Line: 1582-1588

Comment:
**Strip newlines from IFAC strings before writing to config**

`network_name` and `passphrase` are the first user-supplied arbitrary strings written directly into the Reticulum INI config file (all other values, such as `frequency`, `bandwidth`, `interface_mode`, etc., are numeric or known-safe enum strings). An embedded newline — e.g. from a crafted JSON payload sent to the service — would split the value across lines, either silently truncating it or injecting spurious INI content below it.

The Android UI prevents this via `singleLine = true`, but a defensive strip on the Python side would close the gap at the write boundary:

```suggestion
                    # IFAC parameters
                    network_name = iface.get("network_name")
                    if network_name:
                        config_lines.append(f"    network_name = {network_name.replace(chr(10), '').replace(chr(13), '')}")

                    passphrase = iface.get("passphrase")
                    if passphrase:
                        config_lines.append(f"    passphrase = {passphrase.replace(chr(10), '').replace(chr(13), '')}")
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (4): Last reviewed commit: "fix: skip to Review step when editing ex..." | Re-trigger Greptile}