Skip to content

ci: trigger CI on release/* branches#660

Merged
torlando-tech merged 1 commit intomainfrom
ci/add-release-branch-triggers-main
Mar 11, 2026
Merged

ci: trigger CI on release/* branches#660
torlando-tech merged 1 commit intomainfrom
ci/add-release-branch-triggers-main

Conversation

@torlando-tech
Copy link
Copy Markdown
Owner

Summary

  • CI workflow branch filters (v[0-9].[0-9]+.x) didn't match release/v0.9.x — the release/ prefix was missing from the pattern
  • PRs targeting release branches had no lint, compile, or test checks, allowing broken code to be merged (see v0.9.19-beta tagged release failure)
  • Adds 'release/**' to both push and pull_request triggers

Test plan

  • After merge, verify CI triggers on a PR targeting release/v0.9.x

🤖 Generated with Claude Code

The release/v0.9.x branch was not covered by CI because the branch
pattern 'v[0-9].[0-9]+.x' doesn't match the 'release/' prefix. PRs
targeting release branches were merged without lint, compile, or test
checks, which allowed broken cherry-picks to slip through (see the
v0.9.19-beta tagged release failure).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 11, 2026

Greptile Summary

This PR fixes missing CI coverage on release/* branches by adding 'release/**' to both the push and pull_request branch trigger filters in .github/workflows/ci.yml. Previously, only main and branches matching v[0-9].[0-9]+.x triggered CI, meaning PRs targeting branches like release/v0.9.x bypassed all lint, compile, and test checks entirely.

  • Adds 'release/**' to the push trigger branch list
  • Adds 'release/**' to the pull_request trigger branch list
  • The glob pattern release/** correctly matches all branches under the release/ prefix (e.g. release/v0.9.x, release/v1.0.x)

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, correct, and well-scoped CI configuration fix.
  • The change is two lines, symmetric across both trigger types, and uses a standard GitHub Actions glob pattern. It directly addresses the documented failure mode (release branch PRs bypassing CI) without altering any job definitions or secrets handling.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Adds release/** to push and pull_request branch filters so CI runs on release/* branches. Change is minimal, correct, and symmetric across both trigger types.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Code Push / PR Opened] --> B{Branch matches trigger?}
    B -- "main" --> C[CI Triggers ✅]
    B -- "v[0-9].[0-9]+.x\ne.g. v0.9.x" --> C
    B -- "release/**\ne.g. release/v0.9.x\n(NEW - this PR)" --> C
    B -- "other branch" --> D[CI Skipped ❌]
    C --> E[validate-wrapper]
    C --> F[lint]
    C --> G[threading-audit]
    F --> H[proguard-verification]
    F --> I[python-tests]
    F --> J[kotlin-tests x4]
    F --> K[module-tests]
    F --> L[instrumented-tests]
    E --> H
    H & I & J & K & L --> M[ci-passed]
Loading

Last reviewed commit: 3345488

@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@torlando-tech torlando-tech merged commit 290fffd into main Mar 11, 2026
15 checks passed
@torlando-tech torlando-tech deleted the ci/add-release-branch-triggers-main branch March 11, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant