Greptile Summary

This PR removes cherry-pick artifacts from commit ae1cbd26b that broke compilation on the release/v0.9.x branch by referencing symbols (ReceivedLocationRepository, DisposableEffect + background-location permission state/params) that only exist on main. Additionally it corrects a pre-existing incorrect test assertion in test_wrapper_reactions.py that was asserting the wrong post-callback state of pending_inbound.

Key changes:

• SettingsScreen.kt: Removes the DisposableEffect lifecycle observer (which referenced hasForegroundPermission / hasBackgroundPermission via the main-only LocationPermissionManager.hasBackgroundLocationPermission) and the three background-location-permission parameters passed to MessageDeliveryRetrievalCard. All associated state variables are fully eliminated; no orphaned declarations or stale imports remain.
• MessagingViewModel.kt + 2 test files: Drops the unused import com.lxmf.messenger.data.repository.ReceivedLocationRepository that was dragged in by the cherry-pick but is absent on this branch.
• python/test_wrapper_reactions.py: Fixes test_on_lxmf_delivery_regular_message_not_treated_as_reaction to accurately reflect the real _on_lxmf_delivery flow — pre-populating pending_inbound before the callback fires, preventing MagicMock attribute pollution on _columba_rssi/_columba_snr, and asserting len == 0 (message is removed after successful callback) instead of the previously wrong len == 1.

Confidence Score: 5/5

• This PR is safe to merge — it removes dead/broken code introduced by a mis-targeted cherry-pick and fixes a corresponding test assertion.
• All changes are purely subtractive: they remove code that was never meant to land on this branch and fix an incorrect test expectation to match already-shipping production behaviour. No new logic is introduced, no API surface changes, and the PR description documents that compileNoSentryDebugKotlin and all four ViewModel test suites pass.
• No files require special attention; python/test_wrapper_reactions.py deserves a quick read to confirm the new test assertion matches the production _on_lxmf_delivery removal logic, but it does.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant LR as LXMF Router
    participant RW as ReticulumWrapper._on_lxmf_delivery
    participant PI as router.pending_inbound
    participant KC as kotlin_message_received_callback

    LR->>PI: append(lxmf_message)
    LR->>RW: callback fires
    RW->>PI: check: message already in queue? (skip re-add)
    RW->>KC: invoke with full message event
    KC-->>RW: success
    RW->>PI: remove(lxmf_message)
    Note over PI: queue length 0 after successful delivery

_{Last reviewed commit: 4c853c3}

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!