Greptile Summary

This PR fixes a bug where message notifications were incorrectly suppressed while a conversation was open but the device screen was off or the app was backgrounded — because the ViewModel's active-conversation state persists across those lifecycle events. The fix wraps the suppression guard with a ProcessLifecycleOwner foreground check via an injected isAppInForeground lambda, ensuring notifications are only suppressed when the user can actually see the conversation.

• Adds ProcessLifecycleOwner-backed isAppInForeground lambda to NotificationHelper and gates active-conversation suppression on it
• Adds lifecycle-process dependency (already catalogued in libs.versions.toml)
• Adds a new test for the backgrounded-but-active-conversation case, and updates the existing suppression test to explicitly set isAppInForeground = { true }
• One pre-existing test (notifyMessageReceived not suppressed for different conversation) no longer exercises its intended code path because isAppInForeground is not mocked — the test passes via short-circuit rather than verifying the hash-comparison branch, leaving a latent regression gap

Confidence Score: 4/5

• Safe to merge; the core logic fix is correct and the dependency addition is clean, with only a minor test coverage gap to address.
• The ProcessLifecycleOwner.isAtLeast(STARTED) check is the standard Android idiom for detecting foreground state and correctly handles screen-off and app-backgrounded scenarios. The @VisibleForTesting injection approach is well-understood and the new test covers the key new path. Score is 4 rather than 5 solely because one existing test no longer exercises its stated intent due to the missing isAppInForeground mock.
• NotificationHelperTest.kt — the notifyMessageReceived not suppressed for different conversation test needs isAppInForeground = { true } to properly cover the hash-comparison branch.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[notifyMessageReceived called] --> B{Master toggle\nenabled?}
    B -- No --> Z[return — no notification]
    B -- Yes --> C{Message notifications\nenabled?}
    C -- No --> Z
    C -- Yes --> D{Has notification\npermission?}
    D -- No --> Z
    D -- Yes --> E{isAppInForeground?}
    E -- No --> G[Post notification]
    E -- Yes --> F{activeConversation\n== destinationHash?}
    F -- Yes --> Z
    F -- No --> G

_{Last reviewed commit: 7c4713c}

@greptileai

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!