Greptile Summary

This PR is a clean dead-code removal pass following PR #630, which stopped advertising identity-based device names. Because devices no longer advertise an RNS-{hex} name, shouldSkipDiscoveredDevice() was already always returning false (it short-circuits on a null name), the recentlyDeduplicatedIdentities cooldown map was never populated via the scanner path, and BleAdvertiser.setTransportIdentity() was setting state that was never read. Removing all of it is correct and introduces no behavioral change.

Key changes:

• KotlinBLEBridge.kt: Removes shouldSkipDiscoveredDevice(), recentlyDeduplicatedIdentities, deduplicationCooldownMs, the advertiser?.setTransportIdentity() call, and all four recentlyDeduplicatedIdentities.clear() / .remove() sites.
• BleAdvertiser.kt: Removes transportIdentityHash volatile field and setTransportIdentity() method; device name is now set directly without any identity-based computation.
• BleConnectionManager.kt: Removes advertiser.setTransportIdentity() call; also expression-bodies three trivial private functions.
• BleConstants.kt: Removes IDENTITY_BYTES_IN_ADVERTISED_NAME.
• KotlinBLEBridgeDeduplicationTest.kt: Deletes 15 tests and 6 helpers that exercised the now-deleted code; retains the 5 live tests covering pendingCentralConnections and onAddressChanged.
• docs/ble-architecture.md / detekt-baseline-debug.xml: Updated to match the removed symbols.

Confidence Score: 5/5

• Safe to merge — removes code that was already fully inert since PR fix: stop changing phone's Bluetooth device name during BLE advertising #630 with no live logic affected.
• Every removed call site has been verified against the post-PR fix: stop changing phone's Bluetooth device name during BLE advertising #630 state: shouldSkipDiscoveredDevice always returned false (null name fast-path), the cooldown map was populated but never consulted, and the advertiser identity field was set but never used for name computation. The GATT-layer dedup that actually matters (handleIdentityReceived) is untouched. Tests still compile and the five retained tests cover the live behavior.
• No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[BLE Scanner discovers device] --> B[onDeviceDiscovered callback]
    B --> C["Log: Device discovered (address, name, RSSI)"]
    C --> D[Build serviceUuidsArray]
    D --> E[onDeviceDiscovered.callAttr to Python]

    subgraph REMOVED ["❌ Removed (dead since PR #630)"]
        R1["shouldSkipDiscoveredDevice(device.name)"]
        R2["recentlyDeduplicatedIdentities map"]
        R3["deduplicationCooldownMs = 60,000ms"]
        R4["BleAdvertiser.setTransportIdentity()"]
        R5["IDENTITY_BYTES_IN_ADVERTISED_NAME = 3"]
    end

    subgraph REMAINS ["✅ Remains — GATT-layer dedup"]
        G1[handleIdentityReceived]
        G2{Dual connection?}
        G3[DedupeAction.CLOSE_CENTRAL]
        G4[DedupeAction.CLOSE_PERIPHERAL]
        G1 --> G2
        G2 -- yes --> G3
        G2 -- yes --> G4
    end

    E --> REMAINS

_{Last reviewed commit: eb0c3e1}

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!