Greptile Summary

This PR fixes a coroutine-cancellation leak in AnnounceStreamViewModel by inserting catch (e: CancellationException) { throw e } guards before every broad catch (e: Exception) block — matching the established pattern used elsewhere in the codebase (TelemetryCollectorManager, MessagingViewModel, SettingsViewModel, etc.). The most impactful fix is in the while(true) reachable-count polling loop, which previously continued executing and logging spurious "Job was canceled" errors after viewModelScope was cancelled.

• 9 catch (e: Exception) blocks across updateReachableCount, startCollectingAnnouncesWhenReady, startCollectingAnnounces, toggleContact, triggerAnnounce, setAsMyRelay, unsetRelayAndDelete, deleteAnnounce, and deleteAllAnnounces now all correctly rethrow CancellationException.
• New test reachable count loop stops when viewModelScope is cancelled validates the loop terminates on scope cancellation using advanceTimeBy + runCurrent (correctly avoids advanceUntilIdle() which would hang on the infinite loop).
• TODO comment on onCleared() notes that the viewModelScope.launch { reticulumProtocol.shutdown() } call there is likely ineffective — though the comment's stated reason ("viewModelScope is already cancelled here") is slightly inaccurate: the scope is cancelled after onCleared() returns, not before, meaning the launch succeeds but the coroutine is cancelled before shutdown() can execute.

Confidence Score: 5/5

• Safe to merge — the fix is a well-established Kotlin coroutines pattern, the change is surgical and low-risk, and the new test validates the most critical path.
• All 9 catch blocks are consistently updated, the fix matches the existing codebase convention, the new test is sound, and there are no logic regressions. The only minor issue is a slightly inaccurate TODO comment wording which does not affect runtime behaviour.
• No files require special attention; the TODO on onCleared() is worth following up but is a pre-existing concern unrelated to the correctness of this PR.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[viewModelScope launched coroutine] --> B{try block executes}
    B -->|Normal completion| C[Continue / next iteration]
    B -->|CancellationException thrown| D["catch (e: CancellationException)\n{ throw e }  ← NEW"]
    D --> E[Exception propagates up to launch]
    E --> F[Coroutine / loop terminates cleanly]
    B -->|Other Exception thrown| G["catch (e: Exception)\n{ Log.e(...) }"]
    G --> C
    style D fill:#90ee90,stroke:#228B22
    style F fill:#90ee90,stroke:#228B22

_{Last reviewed commit: 2e49126}

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!