Greptile Summary

This PR introduces a background location permission management flow into the Location Sharing settings: a new BackgroundLocationPermissionBottomSheet explains the "Allow all the time" requirement, a three-state permission indicator row in LocationSharingCard reflects current permission status, and SettingsScreen wires the full grant/refresh lifecycle. The implementation correctly handles all three permission states and refreshes on ON_RESUME when returning from system settings.

Key observations:

• The foreground permission launcher does not explicitly update hasForegroundPermission in its callback, unlike the background launcher which immediately sets hasBackgroundPermission = granted. This creates a stale-state window between the system dialog closing and ON_RESUME firing.
• showTelemetryBackgroundSheet is now shared between the Telemetry Collector enable flow and the new location-sharing indicator tap path. The naming and in-code comment still say "Telemetry Collector only", which is misleading and raises a maintenance risk.
• The clickable permission indicator row in LocationSharingCard is missing a Role.Button semantic, meaning TalkBack will not announce it as interactive.
• No new unit tests were added for the three new parameters on LocationSharingCard (hasForegroundLocationPermission, hasBackgroundLocationPermission, onBackgroundPermissionClick), leaving the three-state indicator logic untested.

Confidence Score: 3/5

• Safe to merge with minor fixes — no data loss or security risks, but stale state window and shared sheet naming should be resolved before shipping.
• The overall permission flow logic correctly handles all three states and the ON_RESUME refresh is solid. However, the asymmetry between foreground and background launcher state updates creates a real stale-state window where the UI can briefly display incorrect state. The showTelemetryBackgroundSheet variable conflating two flows increases maintenance risk. Missing accessibility semantics and test coverage for the new indicator feature further reduce confidence. None of these are blockers, but they should be addressed before release.
• SettingsScreen.kt (foreground launcher state update and shared sheet naming), LocationSharingCard.kt (accessibility semantic), LocationSharingCardTest.kt (test coverage for permission indicator).

Sequence Diagram

sequenceDiagram
    participant User
    participant Indicator as Permission Indicator (LocationSharingCard)
    participant Settings as SettingsScreen
    participant FgSheet as LocationPermissionBottomSheet
    participant BgSheet as BackgroundLocationPermissionBottomSheet
    participant System as Android System Dialog

    User->>Indicator: Tap row
    Indicator->>Settings: onBackgroundPermissionClick()

    alt Background already granted
        Settings->>System: startActivity(ACTION_APPLICATION_DETAILS_SETTINGS)
        Settings-->>User: Toast("Go to Permissions > Location")
    else Foreground granted, background not granted
        Settings->>BgSheet: showTelemetryBackgroundSheet = true
        User->>BgSheet: "Continue"
        BgSheet->>System: launch(ACCESS_BACKGROUND_LOCATION)
        System-->>Settings: granted → hasBackgroundPermission = true
    else No permission at all
        Settings->>FgSheet: showTelemetryPermissionSheet = true (pendingTelemetryAction = null)
        User->>FgSheet: "Grant Location Access"
        FgSheet->>System: launch(ACCESS_FINE_LOCATION)
        System-->>Settings: granted → (hasForegroundPermission NOT set here)
        Settings->>BgSheet: showTelemetryBackgroundSheet = true
        User->>BgSheet: "Continue"
        BgSheet->>System: launch(ACCESS_BACKGROUND_LOCATION)
        System-->>Settings: granted → hasBackgroundPermission = true
    end

    Note over Settings: ON_RESUME also refreshes both<br/>hasForegroundPermission &<br/>hasBackgroundPermission

_{Last reviewed commit: 855e704}

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@greptile