Greptile Summary

This PR implements local message deletion with proper handling of orphaned reply previews. The implementation follows a clean architecture pattern from UI → ViewModel → Repository → DAO.

Key changes:

• Data layer: ConversationRepository.deleteMessage() uses @Transaction to atomically delete the message and update the conversation's last message preview
• ViewModel: Invalidates reply preview cache entries that reference deleted messages, replacing them with empty sender name and "Message deleted" text
• UI: Delete button added to message long-press overlay with confirmation dialog
• Graceful degradation: Orphaned reply previews display placeholder text, tapping them is a no-op (no crash)

Observations:

• Local-only deletion (message not recalled from recipient) is clearly documented
• Test coverage validates reply preview cache invalidation and null-safety when no active conversation
• The PR also includes unrelated fixes: RNS Discovery import and LXST-kt submodule update

Confidence Score: 5/5

• Safe to merge with minimal risk
• Clean implementation with proper transaction handling, comprehensive test coverage for edge cases, and graceful handling of orphaned replies. No logic errors, race conditions, or security issues found.
• No files require special attention

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User long-presses message] --> B[MessageActionButtons displayed]
    B --> C[User taps Delete button]
    C --> D[Delete confirmation dialog shown]
    D --> E{User confirms?}
    E -->|Cancel| F[Dialog dismissed, return to chat]
    E -->|Delete| G[ViewModel.deleteMessage called]
    G --> H[ConversationRepository.deleteMessage]
    H --> I[Delete message from DB]
    I --> J[Get new last message]
    J --> K{Messages remain?}
    K -->|Yes| L[Update conversation lastMessage/timestamp]
    K -->|No| M[Clear conversation lastMessage/timestamp]
    L --> N[ViewModel updates reply preview cache]
    M --> N
    N --> O{Reply previews reference deleted message?}
    O -->|Yes| P[Replace with 'Message deleted' placeholder]
    O -->|No| Q[Cache unchanged]
    P --> R[UI updates, orphaned replies show placeholder]
    Q --> R
    R --> S[User taps orphaned reply preview]
    S --> T{Message exists in messagePositions?}
    T -->|No| U[No-op, no scroll]
    T -->|Yes| V[Scroll to message]

_{Last reviewed commit: 1fabe9f}

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!