Greptile Summary

Addresses Android 13+ behavior where foreground notifications can be dismissed by user swipe. Routes all notification updates through Service.startForeground() instead of NotificationManager.notify() since only the former can restore dismissed notifications. Adds notification reinforcement triggers in MainActivity.onResume() and ReticulumService.onRebind() to handle edge cases.

Key Changes:

• Introduced repostNotification() helper that uses startForeground() for all notification updates
• Stores service reference in ServiceNotificationManager to enable startForeground() calls from notification update paths
• Added onResume() trigger in MainActivity to restore notification when app reopens
• Added onRebind() in ReticulumService to handle service rebinding edge case
• All five notification update call sites now route through repostNotification()

Implementation Quality:

• Clean architecture with centralized notification posting logic
• Proper null safety with local variable copy in repostNotification()
• Appropriate exception handling in MainActivity.onResume()
• Maintains consistent foreground service type across Android versions

Confidence Score: 5/5

• Safe to merge - addresses specific Android 13+ notification behavior with solid implementation
• Well-structured fix with proper null safety, exception handling, and version checks. All notification paths correctly route through the new helper. Changes are focused and address the stated problem without introducing complexity or breaking existing functionality.
• No files require special attention

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant User
    participant MainActivity
    participant ReticulumService
    participant NotificationMgr as ServiceNotificationManager
    participant Android

    Note over User,Android: User swipes away notification (Android 13+)
    User->>Android: Swipe notification
    Android-->>NotificationMgr: Notification dismissed

    Note over User,Android: User reopens app
    User->>MainActivity: Open app
    MainActivity->>MainActivity: onResume()
    MainActivity->>ReticulumService: startForegroundService(ACTION_START)
    ReticulumService->>ReticulumService: onStartCommand()
    ReticulumService->>NotificationMgr: startForeground(service)
    NotificationMgr->>Android: Service.startForeground()
    Android-->>User: Notification restored

    Note over User,Android: Service rebind edge case
    MainActivity->>ReticulumService: rebind service
    ReticulumService->>ReticulumService: onRebind()
    ReticulumService->>NotificationMgr: startForeground(service)
    NotificationMgr->>Android: Service.startForeground()

    Note over User,Android: Regular notification updates
    NotificationMgr->>NotificationMgr: updateNotification()
    NotificationMgr->>NotificationMgr: repostNotification()
    NotificationMgr->>Android: Service.startForeground()
    Note right of NotificationMgr: All updates use startForeground()<br/>instead of notify()

_{Last reviewed commit: 1a772b8}

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!