fix: RNode announces via BLE shown with Bluetooth icon#525
Merged
torlando-tech merged 1 commit intomainfrom Feb 22, 2026
Merged
fix: RNode announces via BLE shown with Bluetooth icon#525torlando-tech merged 1 commit intomainfrom
torlando-tech merged 1 commit intomainfrom
Conversation
RNode interfaces connected via BLE get names like "ColumbaRNodeInterface[RNode 5A3F BLE]". The `fromInterfaceName()` and `categorizeInterface()` functions checked for "ble" before "rnode", so these were misclassified as ANDROID_BLE/BLUETOOTH instead of RNODE/LORA. Reorder the when-branches so "rnode" is checked before "ble" in both InterfaceType and ReceivingInterfaceInfo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Greptile SummaryFixes a bug where RNode interfaces connected via BLE were incorrectly categorized as Bluetooth devices instead of LoRa/RNode devices. The issue occurred because interface names like Changes:
The fix ensures RNode devices are always correctly classified regardless of their connection transport, while preserving correct behavior for genuine BLE interfaces like Confidence Score: 5/5
Important Files Changed
Last reviewed commit: c6863ba |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ColumbaRNodeInterface[RNode 5A3F BLE]fromInterfaceName()andcategorizeInterface()checked for"ble"before"rnode", so these were misclassified as BLE/Bluetooth instead of RNode/LoRawhen-branches so"rnode"is checked before"ble"in bothInterfaceType.ktandReceivingInterfaceInfo.ktTest plan
InterfaceTypeTestfor"ColumbaRNodeInterface[RNode 5A3F BLE]"→RNODEReceivingInterfaceInfoTestfor same name → CellTower icon🤖 Generated with Claude Code