fix: announce interface identification when transport disabled#519
Merged
torlando-tech merged 1 commit intomainfrom Feb 22, 2026
Merged
fix: announce interface identification when transport disabled#519torlando-tech merged 1 commit intomainfrom
torlando-tech merged 1 commit intomainfrom
Conversation
…bled The announce_table in RNS is only populated when transport mode is enabled. On non-transport nodes, interface extraction always returned None, causing announces to show "Unknown" interface. Extract interface lookup into python/interface_lookup.py module that checks announce_table first, then falls back to path_table (which is always populated regardless of transport mode). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Contributor
Greptile SummaryFixed interface identification for announces on devices with transport mode disabled by implementing a fallback mechanism that checks Key changes:
Technical context: Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 9b0d071 |
Contributor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
announce_tablein RNS is only populated when transport is enabled; interface extraction relied solely on itpython/interface_lookup.pythat checksannounce_tablefirst, then falls back topath_table(always populated regardless of transport mode)Changes
python/interface_lookup.py— minimal module withget_receiving_interface()andformat_interface_name()python/reticulum_wrapper.py— import and call the new module (removed duplicated inline extraction from_announce_handlerandpoll_received_announces)python/test_announce_handler.py— updated existing tests, addedtest_path_table_fallback_when_announce_table_missingTest plan
🤖 Generated with Claude Code