fix: send pending file notification eagerly on propagation fallback#514
Merged
torlando-tech merged 2 commits intomainfrom Feb 21, 2026
Merged
fix: send pending file notification eagerly on propagation fallback#514torlando-tech merged 2 commits intomainfrom
torlando-tech merged 2 commits intomainfrom
Conversation
When a large file attachment exceeds the recipient's size limit and falls back to propagation, notify the recipient immediately rather than waiting for propagation to succeed. The previous deferred approach had three bugs that prevented the notification from ever appearing: 1. Tracking entry was placed after the immediate-success return, so synchronous propagation success skipped notification entirely 2. If propagation failed (max_relay_retries_exceeded), the notification was never sent since it waited for success 3. Field 16 (APP_EXTENSIONS_FIELD) was not in the meaningful_fields set, so the recipient's _on_lxmf_delivery filtered the notification as an "empty probe message" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Greptile SummaryFixes a critical bug chain that prevented recipients from receiving pending file notifications when large files fall back to propagation delivery. Key Changes:
Bugs Fixed:
Minor Issues:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 255c148 |
python/reticulum_wrapper.py
Outdated
| # propagation to succeed because: (a) propagation may fail entirely, leaving | ||
| # the recipient uninformed, and (b) the direct link to the recipient likely | ||
| # still works (the original failure was a size-limit rejection, not a path failure). | ||
| if hasattr(lxmf_message, 'fields') and lxmf_message.fields and 5 in lxmf_message.fields: |
Contributor
There was a problem hiding this comment.
use FIELD_FILE_ATTACHMENTS constant instead of magic number 5
Suggested change
| if hasattr(lxmf_message, 'fields') and lxmf_message.fields and 5 in lxmf_message.fields: | |
| if hasattr(lxmf_message, 'fields') and lxmf_message.fields and FIELD_FILE_ATTACHMENTS in lxmf_message.fields: |
Prompt To Fix With AI
This is a comment left during a code review.
Path: python/reticulum_wrapper.py
Line: 4866
Comment:
use `FIELD_FILE_ATTACHMENTS` constant instead of magic number `5`
```suggestion
if hasattr(lxmf_message, 'fields') and lxmf_message.fields and FIELD_FILE_ATTACHMENTS in lxmf_message.fields:
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: python/reticulum_wrapper.py
Line: 552
Comment:
this dictionary is now unused and can be removed
How can I resolve this? If you propose a fix, please make it concise. |
Contributor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meaningful_fieldsset so the recipient doesn't filter the notification as an "empty probe message"Bugs fixed
_pending_file_notificationstracking was placed after the immediate-successreturn, so synchronous propagation success skipped notification entirelymax_relay_retries_exceeded), the notification was never sentmeaningful_fields, so_on_lxmf_deliverydiscarded the notification as a probe messageTest plan
📬 Sending pending file notification eagerly📨 _on_lxmf_delivery CALLED!followed by✅ Added message to pending_inbound queue🤖 Generated with Claude Code