fix: use build-time config for copyright year#503
Closed
torlando-tech wants to merge 1 commit intomainfrom
Closed
Conversation
Use BuildConfig.COPYRIGHT_YEAR (set in build.gradle.kts) instead of dynamic year calculation from the device clock. This prevents users with incorrect system time from seeing wrong copyright dates. Update yearly by changing the value in build.gradle.kts. Closes #490 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Greptile Summaryreplaced hardcoded copyright year with build-time configuration to prevent users with incorrect device clocks from seeing wrong copyright dates
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 3e27b29 |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Owner
Author
|
Superseded by clean single-commit PRs targeting both main and release/v0.8.x |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded "2025" copyright year with
BuildConfig.COPYRIGHT_YEAR, set at build time inbuild.gradle.kts. This supersedes PRs #495 and #496 which usedCalendar.getInstance().get(Calendar.YEAR)— a runtime approach that reads from the device's system clock, which users can set to any date.Why not dynamic year?
GIT_COMMIT_HASHandBUILD_TIMESTAMP)Maintenance: Update the
COPYRIGHT_YEARvalue inapp/build.gradle.ktsonce per year.Closes #490
Supersedes #495, #496
Test plan
🤖 Generated with Claude Code