Greptile Summary

This PR adds post-flash firmware verification to RNodeFlasher.provisionDevice(), addressing #489 where a device that fails to reboot after flashing (e.g., DTR/RTS lines not wired) would silently report success.

• Firmware version comparison: After reconnecting to the device post-flash, the reported firmwareVersion is compared against the expected version from FirmwarePackage.version. If they don't match, a clear error is shown instead of false success.
• Firmware hash read-back verification: After writing the firmware hash to EEPROM via setFirmwareHash(), the actual boot-computed hash is read back via getFirmwareHash() and compared against the pre-calculated binary hash. A mismatch indicates the device is still running old firmware.
• Both checks are applied in two code paths within provisionDevice(): the "already provisioned" branch and the "fresh provisioning + reset" branch.
• The flashFirmwareAutoDetect path and onDeviceManuallyReset path don't receive expectedFirmwareVersion since they don't have access to a FirmwarePackage, so the version check is skipped there (hash check may still apply if firmwareHash is provided).
• The verification logic is duplicated across three locations within provisionDevice(); extracting it into helper methods would improve maintainability.

Confidence Score: 4/5

• This PR is safe to merge — it adds defensive verification checks without altering the happy path behavior.
• The core verification logic is correct: firmware version string comparison and boot-computed hash vs binary hash comparison will reliably detect the target failure mode (device not rebooting after flash). The new parameter defaults to null, preserving backward compatibility. The main concern is the missing expectedFirmwareVersion in the onDeviceManuallyReset path, which is a gap in coverage rather than a correctness issue.
• Pay attention to onDeviceManuallyReset (line 900) — it's the one code path that calls provisionDevice without the new expectedFirmwareVersion parameter, meaning manual-reset flows skip version verification.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant UI as FlasherViewModel
    participant F as RNodeFlasher
    participant D as RNodeDetector
    participant Dev as RNode Device

    UI->>F: flashFirmware(deviceId, firmwarePackage)
    F->>F: calculateFirmwareBinaryHash()
    F->>Dev: Flash firmware (ESP32/NRF52)
    F->>F: Wait for reboot
    F->>F: provisionDevice(deviceId, board, band, firmwareHash, expectedVersion)

    alt Device already provisioned
        F->>D: getDeviceInfo()
        D->>Dev: Query firmware version
        Dev-->>D: firmwareVersion
        D-->>F: RNodeDeviceInfo

        Note over F: NEW: Version verification
        F->>F: Compare deviceInfo.firmwareVersion vs expectedVersion
        alt Version mismatch
            F-->>UI: FlashState.Error("version mismatch")
        end

        F->>D: setFirmwareHash(firmwareHash)
        D->>Dev: Write target hash to EEPROM

        Note over F: NEW: Hash verification
        F->>D: getFirmwareHash()
        D->>Dev: Read actual boot-computed hash
        Dev-->>D: actualHash
        D-->>F: actualHash
        F->>F: Compare actualHash vs firmwareHash
        alt Hash mismatch
            F-->>UI: FlashState.Error("hash mismatch")
        end

        F-->>UI: FlashState.Complete
    else Device needs provisioning
        F->>D: provisionAndSetFirmwareHash()
        D->>Dev: Write EEPROM + hash
        F->>D: resetDevice()
        F->>F: Wait for reboot
        F->>D: getDeviceInfo()
        D-->>F: verifiedInfo

        Note over F: NEW: Post-provision version verification
        F->>F: Compare verifiedInfo.firmwareVersion vs expectedVersion
        alt Version mismatch
            F-->>UI: FlashState.Error("version mismatch")
        end

        F-->>UI: FlashState.Complete
    end

_{Last reviewed commit: 8d642dd}

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!