Skip to content

fix: keep geohash field and Next button visible when keyboard opens#492

Merged
torlando-tech merged 2 commits intomainfrom
fix/offline-map-keyboard-scroll
Feb 18, 2026
Merged

fix: keep geohash field and Next button visible when keyboard opens#492
torlando-tech merged 2 commits intomainfrom
fix/offline-map-keyboard-scroll

Conversation

@torlando-tech
Copy link
Copy Markdown
Owner

Summary

  • Adds imePadding() to the location selection step so the content shrinks above the soft keyboard
  • Restructures the layout to pin the Next button at the bottom, outside the scrollable area, so it's always accessible even with the keyboard open

Test plan

  • Open offline map download, tap the geohash text field
  • Verify the keyboard pushes content up — geohash field and Next button both visible
  • Verify the form is still scrollable with keyboard open (can reach lat/lon fields)
  • Verify layout looks correct on larger displays without keyboard

🤖 Generated with Claude Code

On the offline map download location step, the geohash text field was
hidden behind the soft keyboard on shorter displays. Adds imePadding()
and restructures the layout so the scrollable form fields shrink above
the keyboard while the Next button stays pinned at the bottom.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@torlando-tech torlando-tech linked an issue Feb 18, 2026 that may be closed by this pull request
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 18, 2026

Greptile Summary

Restructured the LocationSelectionStep layout to improve keyboard handling and ensure the Next button remains accessible.

Key changes:

  • Added imePadding() modifier to the root Column so content adjusts when the keyboard opens
  • Wrapped scrollable content in nested Column with weight(1f) to allow proper flex layout
  • Moved Next button outside the scrollable area so it stays pinned at the bottom
  • Replaced Spacer(modifier = Modifier.weight(1f)) with fixed height spacer for proper layout behavior

The implementation follows Android best practices for handling IME insets in Compose. The layout structure now ensures that when the keyboard appears, the geohash field and Next button remain visible while still allowing the form to scroll to access other fields like latitude/longitude.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are focused, well-structured, and follow Compose best practices for keyboard handling. The layout restructuring is clean and doesn't introduce any logical issues.
  • No files require special attention

Important Files Changed

Filename Overview
app/src/main/java/com/lxmf/messenger/ui/screens/offlinemaps/OfflineMapDownloadScreen.kt Restructured LocationSelectionStep layout to pin Next button and handle keyboard with imePadding()

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Root Column<br/>fillMaxSize + imePadding + padding] --> B[Inner Column<br/>weight 1f + fillMaxWidth + verticalScroll]
    A --> C[Spacer<br/>height 16.dp]
    A --> D[Next Button<br/>fillMaxWidth - pinned at bottom]
    
    B --> E[Warning Banner]
    B --> F[Instructions Text]
    B --> G[Current Location Button]
    B --> H[Lat/Lon TextFields]
    B --> I[Address Search conditional]
    B --> J[Geohash TextField]
    B --> K[Location Confirmation Card]
    
    style A fill:#e1f5ff
    style B fill:#fff9c4
    style D fill:#c8e6c9
    style J fill:#ffccbc
Loading

Last reviewed commit: f398999

…ard-scroll

# Conflicts:
#	app/src/main/java/com/lxmf/messenger/ui/screens/offlinemaps/OfflineMapDownloadScreen.kt
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@torlando-tech torlando-tech merged commit e8c2fed into main Feb 18, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geohash is been hidden behind the keyboard when you press on it

1 participant