Add Password keyboard type to password input fields#475
Merged
torlando-tech merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
…stions Add KeyboardOptions(keyboardType = KeyboardType.Password) to both password OutlinedTextField fields in PasswordDialog. This tells the on-screen keyboard to use incognito mode, preventing it from showing or learning password text in suggestions. https://claude.ai/code/session_01TjG6GLMhjnTX8SNxRDQz6Q
Contributor
Greptile SummaryAdds
Confidence Score: 5/5
Important Files Changed
Flowchartflowchart TD
A[User opens PasswordDialog] --> B[OutlinedTextField: Password]
A --> C[OutlinedTextField: Confirm Password]
B --> D[keyboardOptions: KeyboardType.Password]
C --> E[keyboardOptions: KeyboardType.Password]
D --> F[Keyboard disables autocorrect & suggestions]
E --> F
B --> G[visualTransformation: PasswordVisualTransformation]
C --> G
G --> H[Characters hidden unless toggled visible]
F --> I[Improved password input UX]
H --> I
Last reviewed commit: f6d9ad4 |
Comment on lines
+59
to
+60
| import androidx.compose.foundation.text.KeyboardOptions | ||
| import androidx.compose.ui.text.input.KeyboardType |
Contributor
There was a problem hiding this comment.
Import ordering is inconsistent
The new KeyboardOptions import from androidx.compose.foundation.text is placed after the androidx.compose.ui block (line 58), but the rest of the file groups androidx.compose.foundation.* imports together at lines 8–21. Moving this import up to that group would keep the file consistent with its existing alphabetical ordering convention.
Suggested change
| import androidx.compose.foundation.text.KeyboardOptions | |
| import androidx.compose.ui.text.input.KeyboardType | |
| import androidx.compose.ui.text.input.KeyboardType |
And add at line 21 (after import androidx.compose.foundation.verticalScroll):
import androidx.compose.foundation.text.KeyboardOptions
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/src/main/java/com/lxmf/messenger/ui/screens/MigrationScreen.kt
Line: 59:60
Comment:
**Import ordering is inconsistent**
The new `KeyboardOptions` import from `androidx.compose.foundation.text` is placed after the `androidx.compose.ui` block (line 58), but the rest of the file groups `androidx.compose.foundation.*` imports together at lines 8–21. Moving this import up to that group would keep the file consistent with its existing alphabetical ordering convention.
```suggestion
import androidx.compose.ui.text.input.KeyboardType
```
And add at line 21 (after `import androidx.compose.foundation.verticalScroll`):
```
import androidx.compose.foundation.text.KeyboardOptions
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added proper keyboard type configuration to password input fields in the MigrationScreen's PasswordDialog to improve user experience on mobile devices.
Key Changes
KeyboardOptionsimport fromandroidx.compose.foundation.textKeyboardTypeimport fromandroidx.compose.ui.text.inputkeyboardOptions = KeyboardOptions(keyboardType = KeyboardType.Password)to the password input fieldkeyboardOptions = KeyboardOptions(keyboardType = KeyboardType.Password)to the confirm password input fieldImplementation Details
By setting the keyboard type to
KeyboardType.Password, the on-screen keyboard will now display appropriate input options for password fields (typically hiding characters and disabling autocorrect/suggestions). This improves the user experience when entering passwords on mobile devices and follows Android/Compose best practices for sensitive input fields.https://claude.ai/code/session_01TjG6GLMhjnTX8SNxRDQz6Q