Codecov Report

❌ Patch coverage is 32.33533% with 113 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!

Greptile Summary

This PR fixes two issues with MBTiles imports: (1) maps without center metadata no longer default to 0,0 (Gulf of Guinea) by deriving the center from bounds, and (2) raster tile MBTiles files (PNG/JPEG) are now rendered correctly via auto-detected style generation.

• Center fallback from bounds: OfflineMapRegionRepository.extractMbtilesMetadata now parses bounds before center, using the bounds midpoint as a fallback when center metadata is absent. The radius calculation is also simplified with nullable types.
• Raster style generation: New buildRasterOfflineStyle and buildAutoOfflineStyle methods in OfflineMapStyleBuilder detect tile format via the MBTiles metadata table and generate the appropriate MapLibre style JSON.
• Style caching on import: OfflineMapsViewModel now generates and caches the style JSON file during both user-initiated imports and orphaned file recovery, stored under offline_styles/{regionId}.json and persisted via updateLocalStylePath.
• The getTileFormat function duplicates the SQLite database access already performed by extractMbtilesMetadata during the same import flow. Consider consolidating to avoid opening the database twice.
• No new unit tests are added for the three new public methods (buildRasterOfflineStyle, buildAutoOfflineStyle, getTileFormat), and the test plan shows vector MBTiles verification is still unchecked.

Confidence Score: 4/5

• This PR is safe to merge with low risk — changes are well-structured with proper error handling and fallbacks.
• The core logic changes (center derivation from bounds, raster style generation) are straightforward and correct. Error handling is defensive with non-fatal catches. The only concerns are minor: duplicate database access during import, and lack of new unit tests for the three added public methods. No runtime-breaking issues found.
• OfflineMapStyleBuilder.kt has new public methods without test coverage and a duplicate database access pattern.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant User
    participant VM as OfflineMapsViewModel
    participant Repo as OfflineMapRegionRepository
    participant Builder as OfflineMapStyleBuilder
    participant DB as SQLiteDatabase
    participant FS as FileSystem

    User->>VM: importMbtilesFile(uri)
    VM->>FS: Copy URI to offline_maps/
    VM->>Repo: importOrphanedFile(file)
    Repo->>DB: Open MBTiles SQLite (extractMbtilesMetadata)
    DB-->>Repo: metadata (name, bounds, center, zoom)
    Note over Repo: Derive center from bounds<br/>if center metadata missing
    Repo->>Repo: Insert OfflineMapRegionEntity
    Repo-->>VM: regionId

    VM->>VM: cacheStyleForRegion(regionId, file, name)
    VM->>Builder: buildAutoOfflineStyle(path, name)
    Builder->>DB: Open MBTiles SQLite (getTileFormat)
    DB-->>Builder: format (pbf/png/jpg)
    alt format == "pbf"
        Builder->>Builder: buildOfflineStyle (vector)
    else format != "pbf"
        Builder->>Builder: buildRasterOfflineStyle (raster)
    end
    Builder-->>VM: styleJson

    VM->>FS: Write offline_styles/{regionId}.json
    VM->>Repo: updateLocalStylePath(regionId, path)

_{Last reviewed commit: 5a9b6c3}