Skip to content

Add option to unset group host in location sharing settings#473

Merged
torlando-tech merged 1 commit intomainfrom
claude/unset-telemetry-group-host-Py23P
Feb 16, 2026
Merged

Add option to unset group host in location sharing settings#473
torlando-tech merged 1 commit intomainfrom
claude/unset-telemetry-group-host-Py23P

Conversation

@torlando-tech
Copy link
Copy Markdown
Owner

Summary

Added the ability to clear/unset the selected group host in the location sharing settings dialog by introducing a "None" option at the top of the contact picker list.

Key Changes

  • Added onUnset callback parameter to GroupHostPickerDialog function
  • Implemented "None" option in the contact picker that appears when a host is currently selected
  • The "None" option triggers the onUnset callback and closes the picker dialog
  • Updated the TelemetryCollectorSection to pass the onUnset handler that clears the collector address

Implementation Details

  • The "None" option is conditionally displayed only when selectedHash != null to avoid showing it when no host is selected
  • Uses a Row with a Person icon and "None" text, styled consistently with other contact options
  • Includes a HorizontalDivider to visually separate the "None" option from the contact list
  • The option is placed at the top of the LazyColumn before the sorted contacts list

https://claude.ai/code/session_012ee1TaQ2kHT9VRgsPaYVVa

Add a "None" row to the GroupHostPickerDialog that appears when a group
host is currently selected, allowing users to clear the collector address
and stop sharing telemetry with a group host.

https://claude.ai/code/session_012ee1TaQ2kHT9VRgsPaYVVa
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 16, 2026

Greptile Summary

Added a "None" option at the top of the group host picker dialog to allow users to clear the selected location sharing host. The option is conditionally displayed only when a host is currently selected, and properly triggers the unset callback to clear the collector address.

  • Added onUnset callback parameter to GroupHostPickerDialog
  • Implemented conditional "None" option in the contact picker using selectedHash != null check
  • Used consistent UI styling with Person icon and HorizontalDivider separator
  • Properly integrated with TelemetryCollectorSection to pass null to onCollectorAddressChange

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • The changes are minimal, well-contained, and follow existing patterns. The conditional rendering logic is correct, the callback properly handles the unset action, and the UI styling is consistent with existing code. No logical errors or potential bugs were identified.
  • No files require special attention

Important Files Changed

Filename Overview
app/src/main/java/com/lxmf/messenger/ui/screens/settings/cards/LocationSharingCard.kt Added "None" option to unset group host in location sharing settings - properly implemented with conditional rendering and correct callback handling

Flowchart

flowchart TD
    A[User Opens Group Host Picker] --> B{Is Host Selected?}
    B -->|Yes| C[Show 'None' Option]
    B -->|No| D[Show Contact List Only]
    C --> E[Display Contact List]
    D --> E
    E --> F{User Action}
    F -->|Clicks 'None'| G[onUnset Callback]
    F -->|Selects Contact| H[onContactSelected Callback]
    F -->|Dismisses Dialog| I[onDismiss Callback]
    G --> J[Set Collector Address to null]
    H --> K[Set Collector Address to Contact Hash]
    I --> L[Close Dialog]
    J --> L
    K --> L
Loading

Last reviewed commit: 6c75a33

@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...r/ui/screens/settings/cards/LocationSharingCard.kt 0.00% 23 Missing ⚠️

📢 Thoughts on this report? Let us know!

@torlando-tech torlando-tech linked an issue Feb 16, 2026 that may be closed by this pull request
@torlando-tech torlando-tech merged commit 9acb3b3 into main Feb 16, 2026
10 of 11 checks passed
@torlando-tech torlando-tech deleted the claude/unset-telemetry-group-host-Py23P branch February 16, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mechanism to unset group host (location)

2 participants