Add option to unset group host in location sharing settings#473
Merged
torlando-tech merged 1 commit intomainfrom Feb 16, 2026
Merged
Add option to unset group host in location sharing settings#473torlando-tech merged 1 commit intomainfrom
torlando-tech merged 1 commit intomainfrom
Conversation
Add a "None" row to the GroupHostPickerDialog that appears when a group host is currently selected, allowing users to clear the collector address and stop sharing telemetry with a group host. https://claude.ai/code/session_012ee1TaQ2kHT9VRgsPaYVVa
Contributor
Greptile SummaryAdded a "None" option at the top of the group host picker dialog to allow users to clear the selected location sharing host. The option is conditionally displayed only when a host is currently selected, and properly triggers the unset callback to clear the collector address.
Confidence Score: 5/5
Important Files Changed
Flowchartflowchart TD
A[User Opens Group Host Picker] --> B{Is Host Selected?}
B -->|Yes| C[Show 'None' Option]
B -->|No| D[Show Contact List Only]
C --> E[Display Contact List]
D --> E
E --> F{User Action}
F -->|Clicks 'None'| G[onUnset Callback]
F -->|Selects Contact| H[onContactSelected Callback]
F -->|Dismisses Dialog| I[onDismiss Callback]
G --> J[Set Collector Address to null]
H --> K[Set Collector Address to Contact Hash]
I --> L[Close Dialog]
J --> L
K --> L
Last reviewed commit: 6c75a33 |
Contributor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the ability to clear/unset the selected group host in the location sharing settings dialog by introducing a "None" option at the top of the contact picker list.
Key Changes
onUnsetcallback parameter toGroupHostPickerDialogfunctiononUnsetcallback and closes the picker dialogTelemetryCollectorSectionto pass theonUnsethandler that clears the collector addressImplementation Details
selectedHash != nullto avoid showing it when no host is selectedRowwith aPersonicon and "None" text, styled consistently with other contact optionsHorizontalDividerto visually separate the "None" option from the contact listhttps://claude.ai/code/session_012ee1TaQ2kHT9VRgsPaYVVa