fix: disable RNodeCompanionService on pre-API 31 devices#471
Merged
torlando-tech merged 1 commit intomainfrom Feb 15, 2026
Merged
fix: disable RNodeCompanionService on pre-API 31 devices#471torlando-tech merged 1 commit intomainfrom
torlando-tech merged 1 commit intomainfrom
Conversation
CompanionDeviceService (API 31) superclass causes class verification crash on Samsung S8 (API 26-28) even though runtime code is guarded. Use resource-qualified android:enabled to gate the service at the manifest level so it's never loaded on older devices. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Greptile SummaryFixes a startup crash on pre-API 31 devices (e.g., Samsung Galaxy S8 on API 26-28) caused by class verification of
Confidence Score: 5/5
Important Files Changed
Flowchartflowchart TD
A[App Startup] --> B{Device API Level?}
B -->|API < 31| C["values/companion_service.xml\nenable_companion_service = false"]
B -->|API >= 31| D["values-v31/companion_service.xml\nenable_companion_service = true"]
C --> E["RNodeCompanionService\nandroid:enabled = false"]
D --> F["RNodeCompanionService\nandroid:enabled = true"]
E --> G["Service skipped by system\nNo class verification crash"]
F --> H["Service available for\nCompanion Device binding"]
H --> I["System binds service when\nassociated RNode appears"]
Last reviewed commit: 5ac5afb |
Owner
Author
|
@brothercorvo this should fix your samsung S8 issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompanionDeviceServiceclass verification at startupandroid:enabledattribute to gateRNodeCompanionService— disabled by default (values/), enabled on API 31+ (values-v31/)Context
RNodeCompanionServiceextendsCompanionDeviceService(added in API 31), but the app'sminSdkis 24. Samsung devices perform aggressive class verification on all manifest-declared components, crashing when the superclass doesn't exist — even though the runtime code path is already guarded with API checks.Test plan
assembleNoSentryDebug)android:enabled="@bool/enable_companion_service"🤖 Generated with Claude Code