Replace share intent with SAF file save dialog for exports by torlando-tech · Pull Request #425 · torlando-tech/columba

torlando-tech · 2026-02-09T05:06:06Z

Summary

Changed the export functionality in IdentityManagerScreen and MigrationScreen from using Android's share intent to using the Storage Access Framework (SAF) file save dialog. This provides users with direct control over where exported files are saved, rather than routing through a share sheet.

Key Changes

IdentityManagerScreen: Replaced Intent.ACTION_SEND share sheet with ActivityResultContracts.CreateDocument SAF dialog for identity exports
MigrationScreen: Replaced Intent.ACTION_SEND share sheet with ActivityResultContracts.CreateDocument SAF dialog for data exports
Added pendingExportSourceUri state variable to both screens to track the source file during the save operation
Implemented file copying logic using contentResolver.openInputStream() and openOutputStream() to transfer data from temporary export location to user-selected destination
Updated UI feedback text from "Share sheet opened" to "Save dialog opened"
Removed unused Intent import from MigrationScreen
Added timestamp formatting to MigrationScreen export filename for better organization

Implementation Details

Both screens now use identical export save launcher patterns for consistency
File copying is wrapped in try-catch to gracefully handle errors (user will see empty/corrupt file if something fails)
The pendingExportSourceUri is cleared after the save operation completes
Export filenames are now user-customizable through the SAF dialog ("identity.rnsidentity" for identity exports, "columba_export_TIMESTAMP.columba" for migration exports)

https://claude.ai/code/session_01UXR4yz6pwyoNDDNXUPzz2s

Data export and identity export now open Android's file save dialog (Storage Access Framework) instead of the share sheet, allowing users to save backup files directly to local storage. Fixes #344 https://claude.ai/code/session_01UXR4yz6pwyoNDDNXUPzz2s

greptile-apps · 2026-02-09T05:08:47Z

Greptile Summary

Replaces Android's share intent with Storage Access Framework (SAF) file save dialog for both identity and data exports, giving users direct control over file save location. The implementation properly handles the export flow by storing temporary URIs and copying files to user-selected destinations.

Both screens now use ActivityResultContracts.CreateDocument with consistent patterns
ViewModels handle file copying with proper error handling and user feedback
Migration export includes timestamp formatting for better file organization
Migration correctly cleans up temp files and resets state after save
Identity export properly tracks source URI for the save operation

Minor issue: IdentityManagerViewModel doesn't clean up _exportedIdentityUri after save, unlike MigrationViewModel which properly nulls out the URI.

Confidence Score: 4/5

This PR is safe to merge with minor cleanup improvement recommended
The SAF implementation is solid with proper error handling and state management. The file copying logic is correct and both flows work consistently. Error handling provides user feedback in ViewModels. The only issue is a minor memory cleanup inconsistency where IdentityManagerViewModel doesn't null out the stored URI after save (unlike MigrationViewModel which does). Previous review comments about silent error handling were already addressed in commit 9a0aeb1.
Pay attention to IdentityManagerViewModel.kt for the URI cleanup improvement

Important Files Changed

Filename	Overview
app/src/main/java/com/lxmf/messenger/viewmodel/IdentityManagerViewModel.kt	Added SAF file save logic with proper error handling; missing cleanup of `_exportedIdentityUri` after save operation
app/src/main/java/com/lxmf/messenger/viewmodel/MigrationViewModel.kt	Added SAF file save logic with error handling and proper cleanup; includes new ExportSaved state for UI feedback

Sequence Diagram

sequenceDiagram
    participant User
    participant Screen as UI Screen
    participant ViewModel
    participant SAF as Storage Access Framework
    participant ContentResolver
    participant FileSystem

    User->>Screen: Click Export
    Screen->>ViewModel: exportIdentity() / startExport()
    ViewModel->>FileSystem: Create temp export file
    FileSystem-->>ViewModel: Return temp URI
    ViewModel->>ViewModel: Store in _exportedIdentityUri / _exportedFileUri
    ViewModel->>Screen: Set ExportReady / ExportComplete state
    Screen->>SAF: Launch CreateDocument dialog
    SAF->>User: Show save file dialog
    User->>SAF: Select location & filename
    SAF-->>Screen: Return destination URI
    Screen->>ViewModel: saveExportedIdentityToFile(uri) / saveExportToFile(uri)
    ViewModel->>ContentResolver: openInputStream(sourceUri)
    ViewModel->>ContentResolver: openOutputStream(destinationUri)
    ContentResolver->>FileSystem: Copy file
    FileSystem-->>ContentResolver: Success
    ContentResolver-->>ViewModel: File copied
    ViewModel->>ViewModel: cleanupExportFiles() [Migration only]
    ViewModel->>Screen: Set Success / ExportSaved state
    Screen->>User: Show success snackbar

_{Last reviewed commit: 9a0aeb1}

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

app/src/main/java/com/lxmf/messenger/ui/screens/IdentityManagerScreen.kt

app/src/main/java/com/lxmf/messenger/ui/screens/MigrationScreen.kt

app/src/main/java/com/lxmf/messenger/ui/screens/IdentityManagerScreen.kt

app/src/main/java/com/lxmf/messenger/ui/screens/MigrationScreen.kt

sentry · 2026-02-09T05:12:54Z

Codecov Report

❌ Patch coverage is 57.62712% with 25 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...a/com/lxmf/messenger/ui/screens/MigrationScreen.kt	22.22%	13 Missing and 1 partial ⚠️
...lxmf/messenger/ui/screens/IdentityManagerScreen.kt	0.00%	7 Missing ⚠️
...mf/messenger/viewmodel/IdentityManagerViewModel.kt	83.33%	2 Missing and 1 partial ⚠️
...com/lxmf/messenger/viewmodel/MigrationViewModel.kt	93.75%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

…g change safety - Move file copy logic from composable callbacks into ViewModel methods (saveExportToFile, saveExportedIdentityToFile) so errors are reported via UiState → snackbar instead of being silently swallowed - Use ViewModel-held source URIs (_exportedFileUri, _exportedIdentityUri) which survive configuration changes, fixing state loss on rotation - Run file copy on Dispatchers.IO to avoid ANR on large exports https://claude.ai/code/session_01UXR4yz6pwyoNDDNXUPzz2s

app/src/main/java/com/lxmf/messenger/ui/screens/MigrationScreen.kt

… feedback - MigrationScreen: reset uiState after launching SAF save dialog to prevent it from re-triggering on configuration changes (rotation) - MigrationViewModel: add onExportSaveDialogLaunched() for state reset, add ExportSaved state, clean up temp file after successful save - IdentityManagerViewModel: show success snackbar after identity file is saved to user-chosen destination - MigrationScreen: show "Export saved successfully" snackbar on save Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

app/src/main/java/com/lxmf/messenger/viewmodel/IdentityManagerViewModel.kt

torlando-tech · 2026-02-15T06:54:16Z

@greptileai

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-15T06:57:10Z

app/src/main/java/com/lxmf/messenger/viewmodel/IdentityManagerViewModel.kt

+        fun saveExportedIdentityToFile(destinationUri: Uri) {
+            val sourceUri = _exportedIdentityUri ?: return
+            viewModelScope.launch {
+                try {
+                    withContext(Dispatchers.IO) {
+                        context.contentResolver.openInputStream(sourceUri)?.use { input ->
+                            context.contentResolver.openOutputStream(destinationUri)?.use { output ->
+                                input.copyTo(output)
+                            }
+                        } ?: error("Could not open identity file")
+                    }
+                    _uiState.value =
+                        IdentityManagerUiState.Success("Identity exported successfully")
+                } catch (e: Exception) {
+                    Log.e(TAG, "Failed to save identity file", e)
+                    _uiState.value =
+                        IdentityManagerUiState.Error("Failed to save identity: ${e.message}")
+                }
+            }


_exportedIdentityUri is never cleared after the save operation completes. Consider adding _exportedIdentityUri = null after line 669 to prevent memory leaks from holding onto the URI reference

Prompt To Fix With AI

This is a comment left during a code review. Path: app/src/main/java/com/lxmf/messenger/viewmodel/IdentityManagerViewModel.kt Line: 652:670 Comment: `_exportedIdentityUri` is never cleared after the save operation completes. Consider adding `_exportedIdentityUri = null` after line 669 to prevent memory leaks from holding onto the URI reference How can I resolve this? If you propose a fix, please make it concise.

…agerViewModel Merge main's encrypted import states (PasswordRequired, WrongPassword, password field on ImportPreview) alongside this branch's ExportSaved state. Also null out _exportedIdentityUri after save and add onCleared() cleanup to prevent holding stale URI references, matching MigrationViewModel's pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Cover saveExportToFile, onExportSaveDialogLaunched, and saveExportedIdentityToFile including success, failure, null URI, and URI cleanup after save scenarios. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sentry · 2026-02-15T20:32:19Z

app/src/main/java/com/lxmf/messenger/viewmodel/MigrationViewModel.kt

+                    withContext(Dispatchers.IO) {
+                        contentResolver.openInputStream(sourceUri)?.use { input ->
+                            contentResolver.openOutputStream(destinationUri)?.use { output ->
+                                input.copyTo(output)
+                            }
+                        } ?: error("Could not open export file")


Bug: A nested safe-call can cause a silent failure if openOutputStream() returns null, resulting in an empty export file without any error being reported.
_{Severity: CRITICAL}

Suggested Fix

Explicitly check the result of contentResolver.openOutputStream(destinationUri). If it is null, throw an error to prevent the silent failure. This can be done by adding another elvis operator check for the inner use block, for example: ...?.use { output -> ... } ?: error("Could not open destination file").

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: app/src/main/java/com/lxmf/messenger/viewmodel/MigrationViewModel.kt#L306-L311 Potential issue: In `MigrationViewModel.saveExportToFile()` and `IdentityManagerViewModel.saveExportedIdentityToFile()`, the file copying logic uses a nested safe-call operator. If `contentResolver.openInputStream(sourceUri)` succeeds but `contentResolver.openOutputStream(destinationUri)` returns null, the inner `?.use` block is silently skipped. The `?: error(...)` at the end of the chain is not triggered because the outer expression is not null. This causes the function to report a successful export, but results in an empty file because no data was written, leading to silent data loss.

greptile-apps bot reviewed Feb 9, 2026

View reviewed changes

app/src/main/java/com/lxmf/messenger/ui/screens/IdentityManagerScreen.kt Outdated Show resolved Hide resolved

app/src/main/java/com/lxmf/messenger/ui/screens/MigrationScreen.kt Outdated Show resolved Hide resolved

sentry bot reviewed Feb 9, 2026

View reviewed changes

app/src/main/java/com/lxmf/messenger/ui/screens/IdentityManagerScreen.kt Show resolved Hide resolved

app/src/main/java/com/lxmf/messenger/ui/screens/MigrationScreen.kt Outdated Show resolved Hide resolved

torlando-tech linked an issue Feb 9, 2026 that may be closed by this pull request

[Minor] Export uses Share sheet and not File Save dialog #344

Closed

torlando-tech added this to the v0.9.0 milestone Feb 9, 2026

sentry bot reviewed Feb 10, 2026

View reviewed changes

app/src/main/java/com/lxmf/messenger/ui/screens/MigrationScreen.kt Show resolved Hide resolved

sentry bot reviewed Feb 15, 2026

View reviewed changes

app/src/main/java/com/lxmf/messenger/viewmodel/IdentityManagerViewModel.kt Show resolved Hide resolved

greptile-apps bot reviewed Feb 15, 2026

View reviewed changes

torlando-tech and others added 2 commits February 15, 2026 15:14

test: add unit tests for SAF export save methods

2b3c8ee

Cover saveExportToFile, onExportSaveDialogLaunched, and saveExportedIdentityToFile including success, failure, null URI, and URI cleanup after save scenarios. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sentry bot reviewed Feb 15, 2026

View reviewed changes

torlando-tech merged commit 266b155 into main Feb 15, 2026
9 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace share intent with SAF file save dialog for exports#425

Replace share intent with SAF file save dialog for exports#425
torlando-tech merged 5 commits intomainfrom
claude/fix-export-save-dialog-JnEWn

torlando-tech commented Feb 9, 2026

Uh oh!

greptile-apps bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentry bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

torlando-tech commented Feb 15, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 15, 2026

Uh oh!

sentry bot Feb 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

torlando-tech commented Feb 9, 2026

Summary

Key Changes

Implementation Details

Uh oh!

greptile-apps bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentry bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

torlando-tech commented Feb 15, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

sentry bot Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps bot commented Feb 9, 2026 •

edited

Loading

sentry bot commented Feb 9, 2026 •

edited

Loading