Dependency Upgrades and Build Improvements#14
Merged
Conversation
The add_to_linker function calls were failing type inference because the compiler couldn't determine the generic parameter D that represents the data access pattern. - Add explicit type annotations for PluginApi::add_to_linker using HasSelf<PluginHost> to specify that the host state provides access to PluginHost - Add explicit type annotations for HostApi::add_to_linker using HasSelf<WasiState> to specify that the host state provides access to the entire WasiState This resolves the "type annotations needed" compilation errors by satisfying the HasData trait bounds required by Wasmtime's component model. Fixes: E0283 type inference errors in engine.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades multiple dependencies and build tools: