Fix: timezone-related test failures in JsonNormalizerTest (#83)#84
Merged
jenspapenhagen merged 1 commit intotoon-format:mainfrom Jan 6, 2026
Merged
Fix: timezone-related test failures in JsonNormalizerTest (#83)#84jenspapenhagen merged 1 commit intotoon-format:mainfrom
jenspapenhagen merged 1 commit intotoon-format:mainfrom
Conversation
…t#83) * Replace hardcoded timezone values with dynamic computation based on system timezone * Update testSQLTime to use time.toLocalTime().format(DateTimeFormatter.ISO_LOCAL_TIME) * Update testSQLTimeStamp to use dateTime.toLocalDateTime().format(DateTimeFormatter.ISO_LOCAL_DATE_TIME) * Update Calendar and GregorianCalendar tests to use input.toInstant().toString() * Add missing DateTimeFormatter import for time formatting
jenspapenhagen
approved these changes
Jan 6, 2026
Contributor
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JsonNormalizerTest in the JToon project contains 4 test cases related to time types that fail in my UTC+8 timezones because they use hardcoded expected values, while JsonNormalizer uses the system default timezone when processing SQL time types.
Linked Issue
Closes #83
Description
Type of Change
Changes Made
For dev.toonformat.jtoon.normalizer.JsonNormalizerTest
Testing
Pre-submission Checklist
Breaking Changes