Drop support for python 3.9 and 3.8 #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Done on top of #417 which needs to be merged first |
astafan8
approved these changes
Nov 8, 2024
d36e96d to
6797daf
Compare
Collaborator
Author
|
@marcosfrenkel @wpfff are you ok with dropping 3.8 and 3.9 |
Collaborator
|
@jenshnielsen yes I am ok with it, I think we are using 3.10 already in a lot of places and where we are not it is a good idea to upgrade |
6797daf to
5ac519f
Compare
5ac519f to
a644083
Compare
Collaborator
|
@jenshnielsen Any updates on this? |
Collaborator
Author
|
@marcosfrenkel Sorry I think this should be fine to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many scientific packages follow spec 0 https://scientific-python.org/specs/spec-0000/ and have dropped support for these python versions. It makes sense to also do this here