Added 20*log10(mag) for Pyqtgraph #395
Conversation
…ade naming conventions more intuitive
marcosfrenkel
left a comment
There was a problem hiding this comment.
The logmag view works great when the data is being plotted in a 2 linear plot. However when you have a 2D plot, the view does not seem to be doing anything. I don't think that needs to work for a 2D plot, but if possible, the option to plot it in that way in a 2D plot should be disabled if it doesn't get fixed
plottr/plot/base.py
Outdated
| magAndPhase = "Mag/Phase" | ||
|
|
||
| #: Natural Logarithmic magnitude and phase | ||
| log10_MagAndPhase = "20*log10(Mag)/Phase" |
There was a problem hiding this comment.
I would just rename it to logMag/Phase or something like that. Like this seems to long for me
…lexRepresentation display
marcosfrenkel
left a comment
There was a problem hiding this comment.
The code is behaving exactly how I thought it would! For some reason something is crashing in the background. It is not stopping it from working, but we should not merge something that is crashing
plottr/plot/pyqtgraph/autoplot.py
Outdated
|
|
||
| #Switch the 1d plots to the logarithmic variation | ||
| if plotItem.plotDataType == PlotDataType.scatter1d and plotItem.subPlot == 0: plotItem.plotDataType = PlotDataType.log10_scatter1d | ||
| if plotItem.plotDataType == PlotDataType.line1d and plotItem.subPlot == 0: plotItem.plotDataType = PlotDataType.log10_line1d |
There was a problem hiding this comment.
convert these 2 lines into 4. There is no need to save on vertical space
plottr/plot/pyqtgraph/autoplot.py
Outdated
| symbolPen=None, symbolSize=symbolSize) | ||
| else: | ||
| elif plotItem.plotDataType == PlotDataType.log10_line1d: | ||
| name = plotItem.labels[-1] if isinstance(plotItem.labels, list) else '' |
There was a problem hiding this comment.
This syntax is cool, but it makes it harder to read compared to a normal if else block
|
|
||
| numAxes: int = 0 | ||
|
|
||
| imagData: bool = False |
There was a problem hiding this comment.
Should there be comments explaining what they are? they look pretty self explanatory but maybe?
plottr/plot/pyqtgraph/autoplot.py
Outdated
| if not val.imag == 0: | ||
| self.figOptions.imagData = True | ||
| break | ||
| if not all(val.imag == 0): |
There was a problem hiding this comment.
This line is currently crashing on my machine
Added 20*log10(mag)/phase graphs for Pyqtgraph backend for plottr-monitr
closes #224