Transfer Datadict form to pandas.dataframe #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosfrenkel
requested changes
May 4, 2023
Collaborator
marcosfrenkel
left a comment
There was a problem hiding this comment.
Please update the branch before I approve and merge this PR
| 1 x2 y2 z2 | ||
| 2 x3 y3 z3 | ||
| ... | ||
| """ |
Collaborator
There was a problem hiding this comment.
Follow the style of documentation found in the file. Docstring is too indented, function name does not follow camel case, no mention of the parameter data, the break-lines are not consistent. Fix spelling mistakes: to _datafarme is nothing, lables.
plottr/data/datadict.py
Outdated
| 2 x3 y3 z3 | ||
| ... | ||
| """ | ||
| dat_set = {} |
| dimension_check = False | ||
|
|
||
| if np.size(data.data_vals(key)) > max_ele: | ||
| max_ele = np.size(data.data_vals(key)) |
Collaborator
There was a problem hiding this comment.
It's usually nice to add a space in between control blocks, makes it more clear where something ends and the next thing starts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edited file: datadict.py; edited functin: datadict_todataframe
transfer any dimension datadict into pandas.dataframe.
def datadict_todataframe(data: DataDict)->pd.DataFrame:
example of use:
DataDict A = ...
DataFrame B = datadict_todataframe(B)