Fix the wrong selection of AppendMode in DDH5Writer.add_data #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@yoshi74ls181 This looks good! nice catch, could you update the branch so that this merges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
DDH5Writer.add_dataselects theAppendModeaccording toDDH5Writer.inserted_rows, which is not incremented correctly.Because of this,
DDH5Writer.add_dataalways selectsAppendMode.noneand unnecessarily re-creates the ddh5 file every time a row of data is added.This bugfix removes the part where
DDH5Writer.add_dataincorrectly sets theAppendModeand letsdatadict_to_hdf5decide whether to re-create or append to the ddh5 file.I have also removed
DDH5Writer.inserted_rowsbecause it is not used anywhere else.