Feature for monitr: show whether a measurement is complete or was interrupted #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Other possibilities for the "interrupted" icon (the top one): |
| f'Folder is already star. Please do not add both __trash__ and __star__ tags in the same folder. ' | ||
| f' \n {path} was deleted ') | ||
| error_msg.setWindowTitle(f'Deleting __star__.tag') | ||
| error_msg.setWindowTitle(f'Deleting __trash__.tag') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a feature to display an icon indicating whether a measurement is complete or was interrupted. The icons look like this:
How it works:
When a
DDH5Writerexits, either a__complete__tag or an__interrupted__tag is created depending on whether the exit is due to an exception or not. Monitr treats the__complete__and__interrupted__tags like the__star__and__trash__tags and displays an icon. In this implementation,__star__and__trash__takes precedence over__complete__and__interrupted__.