Save figure bugfix. #317
Merged
Save figure bugfix. #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found bug when trying to save a histogram plot.
Previously the title for the file created when saving the plot was being gathered from the title meta value in the current data being displayed. The histogram node however, was not saving the title meta value when processing the data, leading into the saving button not working when that happened.
Added a title attribute to the AutoPlot class that updates every time the _plotData method gets called if the title meta value is present in the data that is being processed at the moment.
If for some reason it still cannot find the title, an error will be displayed indicating to the user that it could not find the path instead of crashing.