Skip to content

Fix typechecking with latest PyQt5-stubs #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jenshnielsen merged 23 commits into from
May 3, 2022
Merged

Fix typechecking with latest PyQt5-stubs #279

jenshnielsen merged 23 commits into from
May 3, 2022

Conversation

@jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Apr 30, 2022 •
edited
Loading

TODO

  • Manually check that this did not break anything

@jenshnielsen
towards typechecking with newest pyqtstubs
e4c6f6b
@jenshnielsen
Fix Liskov warning
28bbfe1
@jenshnielsen
handle that item may return None
db07825
@jenshnielsen
fix typo in method call
f7beeef
@jenshnielsen
use optional rather than empty dict
1e20a17
@jenshnielsen
improve runtime typecheck
e8593cd
@jenshnielsen
cast layout to the type used
9a2d1ca
@jenshnielsen
make nodewidget generic in embedded widget type
dea4e02
@jenshnielsen
remove unused import
f97bda0
@jenshnielsen
make FormLeyoutWrapper generic in Elementtype
d2bf282
@jenshnielsen
fix type vs instance of
d385b52
@jenshnielsen
Make DimensionReducerNodeWidget Generic in the type of embedded widget
607b020 
Removes the need to assert type of self.widget
@jenshnielsen
Make generic and revert isinstace checks
2d48c63
@jenshnielsen
work around typing issues in inspectr
0679d9c
@jenshnielsen
handle inability to get correct type for self.layout()
9c94bd2
@jenshnielsen
make node class generic in nodewidget type
7712a73
@jenshnielsen
correctly type getRoles return value
72c3ee7
@jenshnielsen
Allow typing errors in autogenerated code
45201e3
@jenshnielsen
enforce types for ignore hints
2fc3a82
@jenshnielsen
bump pyqt stubs to latest version
c8a078b
@jenshnielsen
Add missing error type
b2d849a
@jenshnielsen
python 3.7 compat use TypedDict from typing_extensions
7daf6a1
astafan8
astafan8 approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @jenshnielsen , thank you for the improvement, especially the Generics look good :)

@jenshnielsen jenshnielsen merged commit a73915d into toolsforexperiments:master May 3, 2022
@jenshnielsen jenshnielsen deleted the pyqtstubs_fix branch May 3, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jenshnielsen @astafan8