Fix/swmrcrash #255
Merged
Fix/swmrcrash #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added option to ignore meta data. added tests for equality checks. by default, compare equality, numerical tolerance is now an option.
rely entirely on OS file locking mechanism which works great (using a new class, ``FileOpener``, that waits until a file is unlocked until a timeout.) use pathlib instead of os.path where it improves the code legibility.
…with hdf5. the swmr one causes issues with Win10.
Fix/swmrcrash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the way we concurrently write/read to hdf5 as SWMR caused issues on windows machines.
on the way, also added/improved tests and some minor improvements to tools (checking for dataset equality, mostly).