On second thought, it may be difficult to do with go/build too. You can import a package using UseAllFiles, which will ignore all tags, but in my testing that tends to expose a lot of errors with packages that have a secondary main package with // +build ignore, or things like that.

build.Package does expose AllTags which tells you which tags are relevant in any way. You could potentially use that to call Import multiple times, but it is tricky to know which values are for GOOS, which are for GOOARCH, and which are to be given as raw tags. Not to mention things like ignore or race should be special cased. Build constraints on a file may always be in an odd combination like // +build !linux,amd64 darwin,!386 in which case I don't have a clue what to do. go/build is also not recursive, so that would need to be done manually as well.

The real problem I have is that running GOOS=windows godep save deletes packages not needed for the windows build. If I then run GOOS=linux godep save, it will add linux dependencies, but delete the windows ones. Perhaps this behavior could be disabled by a flag and print a warning or something like that so I can manually prune things if needed. That may be a simpler solution.

Alternatively, we could do go list 3 times with GOOS=windows linux and darwin, and then merge the deps. A bit of a halfway hack, but it may cover 90% of what causes trouble for people in this situation.

Vendor everything regardless of build tags #271

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions