Skip to content

copy: restore parent directory timestamp after copying contents#140

Merged
tonistiigi merged 1 commit into
tonistiigi:masterfrom
jedevc:copy-dir-contents-timestamp
Nov 14, 2022
Merged

copy: restore parent directory timestamp after copying contents#140
tonistiigi merged 1 commit into
tonistiigi:masterfrom
jedevc:copy-dir-contents-timestamp

Conversation

@jedevc

@jedevc jedevc commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator

🛠️ Fixes moby/buildkit#2884

We need to restore the previous directory FileInfo if it existed prior to attempting to copy content into it.

Comment thread copy/copy.go Outdated
@jedevc jedevc force-pushed the copy-dir-contents-timestamp branch from b96fc76 to bacb70c Compare November 10, 2022 16:08
@jedevc jedevc requested a review from tonistiigi November 10, 2022 16:09
Comment thread copy/copy.go Outdated
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc force-pushed the copy-dir-contents-timestamp branch from bacb70c to 766d471 Compare November 14, 2022 15:30
@tonistiigi tonistiigi merged commit 8c91561 into tonistiigi:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

llb.File doesn't preserve timestamp of destination directory (if it was created)

2 participants