Merged
Conversation
sipsma
approved these changes
Oct 15, 2021
Contributor
sipsma
left a comment
There was a problem hiding this comment.
Was wondering if all parent should be ignored or only when parent directory existed. Went with the former for now
That makes sense to me and seems to fit what we want for the cases you brought up in the other issue.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
a3b50f8 to
a1fafbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows capturing changes made by copy so that buildkit diff can ignore the parent directories when layer blobs are created.
@sipsma
Was wondering if all parent should be ignored or only when parent directory existed. Went with the former for now. In buildkit that would mean that in some cases (eg.
--chown/--chmod) parent dir needs to be manually created before copy. Same question about includepatterns that is little more tricky as parents of the patterns can't be predicted outside of the copy.Signed-off-by: Tonis Tiigi tonistiigi@gmail.com