-
Notifications
You must be signed in to change notification settings - Fork 49
Comparing changes
Open a pull request
base repository: tonistiigi/fsutil
base: 9e7a6df48576
head repository: tonistiigi/fsutil
compare: 36ef4d8c0dbb
- 15 commits
- 13 files changed
- 5 contributors
Commits on Feb 15, 2023
-
Remove the break statement that prevented the file from being closed. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Configuration menu - View commit details
-
Copy full SHA for b689884 - Browse repository at this point
Copy the full SHA b689884View commit details
Commits on Apr 11, 2023
-
The EnableProcessPrivileges function will enable a certain set of privileges for the entire process. I am unsure if enabling/disabling privileges is tracked with some sort of reference counting, but if it's not, when we release those privileges, we disable them for the entire process. This means that if some other go routine requires them, we may end up with undesirable results. The RunWithPrivileges locks the thread in which the function runs, and enables those privileges only in that thread. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Configuration menu - View commit details
-
Copy full SHA for 30ab577 - Browse repository at this point
Copy the full SHA 30ab577View commit details
Commits on Jun 27, 2023
-
Merge pull request #158 from gabriel-samfira/use-run-with-privileges
Use RunWithPrivileges
Configuration menu - View commit details
-
Copy full SHA for b80225e - Browse repository at this point
Copy the full SHA b80225eView commit details -
Merge pull request #153 from gabriel-samfira/fix-leaking-file-handles
Fix leaking file handle
Configuration menu - View commit details
-
Copy full SHA for 22252dd - Browse repository at this point
Copy the full SHA 22252ddView commit details
Commits on Jun 29, 2023
-
walk: avoid stat()'ing files unnecessarily
Before: ``` go test -bench=. . goos: linux goarch: amd64 pkg: github.com/tonistiigi/fsutil cpu: Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz BenchmarkWalker/[1]-target-8 27994 41254 ns/op BenchmarkWalker/[1]-**/target-8 29540 40402 ns/op BenchmarkWalker/[2]-*/target-8 1017 1104834 ns/op BenchmarkWalker/[2]-**/target-8 920 1124731 ns/op BenchmarkWalker/[3]-*/*/target-8 34 40524094 ns/op BenchmarkWalker/[3]-**/target-8 32 40432908 ns/op BenchmarkWalker/[4]-*/*/*/target-8 31 44836714 ns/op BenchmarkWalker/[4]-**/target-8 26 44611379 ns/op BenchmarkWalker/[5]-*/*/*/*/target-8 85 14179975 ns/op BenchmarkWalker/[5]-**/target-8 78 13620031 ns/op BenchmarkWalker/[6]-*/*/*/*/*/target-8 44 23380013 ns/op BenchmarkWalker/[6]-**/target-8 51 22435264 ns/op BenchmarkWalker/[6]-**-!*/*/**-8 2101 580936 ns/op ``` After: ``` go test -bench=. . goos: linux goarch: amd64 pkg: github.com/tonistiigi/fsutil cpu: Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz BenchmarkWalker/[1]-target-8 40788 26219 ns/op BenchmarkWalker/[1]-**/target-8 41642 26998 ns/op BenchmarkWalker/[2]-*/target-8 1725 660271 ns/op BenchmarkWalker/[2]-**/target-8 1806 645525 ns/op BenchmarkWalker/[3]-*/*/target-8 64 17609101 ns/op BenchmarkWalker/[3]-**/target-8 66 17563334 ns/op BenchmarkWalker/[4]-*/*/*/target-8 40 26241578 ns/op BenchmarkWalker/[4]-**/target-8 43 24575370 ns/op BenchmarkWalker/[5]-*/*/*/*/target-8 121 9564283 ns/op BenchmarkWalker/[5]-**/target-8 126 9412483 ns/op BenchmarkWalker/[6]-*/*/*/*/*/target-8 63 18703020 ns/op BenchmarkWalker/[6]-**/target-8 73 17287584 ns/op BenchmarkWalker/[6]-**-!*/*/**-8 3792 273148 ns/op ``` Signed-off-by: Nick Santos <nick.santos@docker.com>
Configuration menu - View commit details
-
Copy full SHA for b9e22fc - Browse repository at this point
Copy the full SHA b9e22fcView commit details -
handle mkdir race for diskwriter
If using the diskwriter hanlders in parallel we might see a common directory being created in parallel, only one will win. This allows us to gracefully retry/re-evaluate when we get a syscall.EEXIST error on the mkdir instead of returning an error.
Configuration menu - View commit details
-
Copy full SHA for 8176e09 - Browse repository at this point
Copy the full SHA 8176e09View commit details -
Merge pull request #161 from coryb/mkdir-race
handle mkdir race for diskwriter
Configuration menu - View commit details
-
Copy full SHA for 4951688 - Browse repository at this point
Copy the full SHA 4951688View commit details -
Merge pull request #160 from nicks/nicks/walkdir
walk: avoid stat()'ing files unnecessarily
Configuration menu - View commit details
-
Copy full SHA for 2bcc6db - Browse repository at this point
Copy the full SHA 2bcc6dbView commit details -
ci: update to FreeBSD 13.2 stable
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for de9b3f4 - Browse repository at this point
Copy the full SHA de9b3f4View commit details -
ci: update runner to latest macos for freebsd job
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 905f4a1 - Browse repository at this point
Copy the full SHA 905f4a1View commit details -
ci: add timeout to freebsd workflow
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 062c2c7 - Browse repository at this point
Copy the full SHA 062c2c7View commit details -
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 61b7e6f - Browse repository at this point
Copy the full SHA 61b7e6fView commit details -
Merge pull request #163 from crazy-max/fix-ci
ci: fix freebsd workflow
Configuration menu - View commit details
-
Copy full SHA for 171984c - Browse repository at this point
Copy the full SHA 171984cView commit details -
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d384523 - Browse repository at this point
Copy the full SHA d384523View commit details -
Merge pull request #162 from tonistiigi/tonistiigi/go-1.20
update to Go 1.20
Configuration menu - View commit details
-
Copy full SHA for 36ef4d8 - Browse repository at this point
Copy the full SHA 36ef4d8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 9e7a6df48576...36ef4d8c0dbb